Skip to content

Simplify the use of wheels for Travis - #1355

Merged
astrofrog merged 8 commits into
astropy:masterfrom
astrofrog:updated-wheels-method
Aug 19, 2013
Merged

astrofrog merged 8 commits into
astropy:masterfrom
astrofrog:updated-wheels-method

Conversation

@astrofrog

Copy link
Copy Markdown
Member

@Cadair has worked on simplifying the use of wheels in Travis for Sunpy, and this implements the same method (using the same wheel house). This will likely not work first go, but we can see more easily this way which wheels are missing.

@astrofrog

Copy link
Copy Markdown
Member Author

@Cadair - it looks like this is going to work great! For now, I only see one wheel file missing: Numpy 1.5.1 on Python 2.7.

@astrofrog

Copy link
Copy Markdown
Member Author

Yay, it works!

@Cadair - we won't merge this until you confirm that it's ok to use your wheelhouse (though we can merge before Numpy 1.5.1 is available since that's just one configuration)

@eteq - can you review this?

@astrofrog

Copy link
Copy Markdown
Member Author

Deliberately restarting Travis to see if the Numpy 1.5.1 wheel works.

@Cadair

Cadair commented Aug 18, 2013

Copy link
Copy Markdown
Member

I am happy for you to merge this and use the wheelhouse. Let us know if you need more in the future.

@eteq

eteq commented Aug 19, 2013

Copy link
Copy Markdown
Member

Wow this is a lot easier than all the weird filename string manipulation I had to do (evidenced by the elimination of the very hacky .travis.pip.wheel. Is the magic taking care of that here all in the --use-wheels option to pip? I wonder if that would have just-worked if I'd done that for the old repo...

Anyway, there is one thing that's missing here, @astrofrog : it looks like -q is no longer included in any of the installs. Is that intended? The reason why it was in there before was that if builds had to fall back on doing the builds, sometimes they get very long, such that the Travis logs get unhappy and difficult to read (although maybe Travis has subsequently fixed that). You're probably not seeing that here because all of the wheels were actually obtained successfully, but if @Cadair's wheelhouse is down for some reason, the logs might suddenly become unreadable.

@astrofrog

Copy link
Copy Markdown
Member Author

@eteq - good point, I'll add back the -q options - I had disabled for debugging.

@eteq

eteq commented Aug 19, 2013

Copy link
Copy Markdown
Member

Ahh, cool. In that case once they're in I think it looks good to go.

@astrofrog

Copy link
Copy Markdown
Member Author

@eteq - I'll merge this now, and we can always update if we decide to have a mirror system (or other backup).

astrofrog added a commit that referenced this pull request Aug 19, 2013
Simplify the use of wheels for Travis
@astrofrog
astrofrog merged commit 8e7ec17 into astropy:master Aug 19, 2013
@astrofrog
astrofrog deleted the updated-wheels-method branch July 5, 2016 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants