Skip to content

Manual backport of #13413#13415

Merged
pllim merged 1 commit intoastropy:v5.0.xfrom
WilliamJamieson:backport/13413
Jun 29, 2022
Merged

Manual backport of #13413#13415
pllim merged 1 commit intoastropy:v5.0.xfrom
WilliamJamieson:backport/13413

Conversation

@WilliamJamieson
Copy link
Contributor

Fix for SimplexLSQFitter with scipy 1.9.0rc1

Description

Manual backport of #13413

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the Extra CI label.
  • Is a change log needed? If yes, did the change log check pass? If no, add the no-changelog-entry-needed label. If this is a manual backport, use the skip-changelog-checks label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but astropy-bot check might be missing; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate backport-X.Y.x label(s) before merge.

….0rc1

Fix for SimplexLSQFitter with scipy 1.9.0rc1
@WilliamJamieson WilliamJamieson added no-changelog-entry-needed Manual Backport skip-changelog-checks Tells bot to skip changlog checks skip-basebranch-check Skip base branch check for direct backports Extra CI Run cron CI as part of PR labels Jun 29, 2022
@pllim pllim added this to the v5.0.5 milestone Jun 29, 2022
@pllim pllim merged commit 241b012 into astropy:v5.0.x Jun 29, 2022
@WilliamJamieson WilliamJamieson deleted the backport/13413 branch June 29, 2022 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Extra CI Run cron CI as part of PR Manual Backport modeling no-changelog-entry-needed skip-basebranch-check Skip base branch check for direct backports skip-changelog-checks Tells bot to skip changlog checks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants