Skip to content

Backport PR #12544 on branch v5.0.x (Fix use of memmap with Table.read and add option to deactivate the masking of invalid values) - #13186

Merged
pllim merged 1 commit into
astropy:v5.0.xfrom
saimn:auto-backport-of-pr-12544-on-v5.0.x
Apr 28, 2022
Merged

Backport PR #12544 on branch v5.0.x (Fix use of memmap with Table.read and add option to deactivate the masking of invalid values)#13186
pllim merged 1 commit into
astropy:v5.0.xfrom
saimn:auto-backport-of-pr-12544-on-v5.0.x

Conversation

@saimn

@saimn saimn commented Apr 27, 2022 •
edited by pllim
Loading

Copy link
Copy Markdown
Contributor

Backport PR #12544 on branch v5.0.x

Description

This pull request is to address ...

Fixes #

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the Extra CI label.
  • Is a change log needed? If yes, did the change log check pass? If no, add the no-changelog-entry-needed label. If this is a manual backport, use the skip-changelog-checks label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but astropy-bot check might be missing; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate backport-X.Y.x label(s) before merge.

@saimn saimn added this to the v5.0.5 milestone Apr 27, 2022
@saimn saimn added skip-basebranch-check Skip base branch check for direct backports skip-changelog-checks Tells bot to skip changlog checks labels Apr 27, 2022
@saimn saimn closed this Apr 27, 2022
@saimn saimn reopened this Apr 27, 2022
@pllim

pllim commented Apr 28, 2022

Copy link
Copy Markdown
Member

Failures are real?

@taldcroft @saimn
Backport PR astropy#12544: Fix use of memmap with Table.read and add …
62abffd 
…option to deactivate the masking of invalid values
@saimn
saimn force-pushed the auto-backport-of-pr-12544-on-v5.0.x branch from 10877e1 to 62abffd Compare April 28, 2022 08:16
@saimn

saimn commented Apr 28, 2022

Copy link
Copy Markdown
Contributor Author

Yes, an import that was no more used on main but still needed for 5.0.x

pllim
pllim approved these changes Apr 28, 2022
View reviewed changes

@pllim pllim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@pllim
pllim merged commit 06df150 into astropy:v5.0.x Apr 28, 2022
@saimn
saimn deleted the auto-backport-of-pr-12544-on-v5.0.x branch April 28, 2022 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pllim pllim pllim approved these changes

Assignees

No one assigned

Labels

io.fits skip-basebranch-check Skip base branch check for direct backports skip-changelog-checks Tells bot to skip changlog checks unified-io

Projects

None yet

Milestone

v5.0.5

Development

Successfully merging this pull request may close these issues.

3 participants

@saimn @pllim @taldcroft