Skip to content

TST: Un-xfail test_iers_a_dl_mirror - #13085

Merged
pllim merged 1 commit into
astropy:mainfrom
pllim:un-xfail-iers-a-dlmirror
Apr 8, 2022
Merged

pllim merged 1 commit into
astropy:mainfrom
pllim:un-xfail-iers-a-dlmirror

Conversation

@pllim

@pllim pllim commented Apr 8, 2022 •

Copy link
Copy Markdown
Member

Description

I think it is back online.

Close #12998

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the Extra CI label.
  • Is a change log needed? If yes, did the change log check pass? If no, add the no-changelog-entry-needed label. If this is a manual backport, use the skip-changelog-checks label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but astropy-bot check might be missing; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate backport-X.Y.x label(s) before merge.

because service is back online.
@pllim

pllim commented Apr 8, 2022

Copy link
Copy Markdown
Member Author

numpy dev failure is unrelated. The important thing is xpass isn't there anymore for the IERS A mirror test.

@pllim
pllim requested review from eteq and mhvk April 8, 2022 19:55

@mhvk mhvk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much, @pllim!

@pllim
pllim merged commit 4172ead into astropy:main Apr 8, 2022
@pllim
pllim deleted the un-xfail-iers-a-dlmirror branch April 8, 2022 20:06
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Apr 8, 2022
@pllim

pllim commented Apr 8, 2022

Copy link
Copy Markdown
Member Author

@meeseeksdev backport to v5.0.x

pllim added a commit that referenced this pull request Apr 9, 2022
…085-on-v5.0.x

Backport PR #13085 on branch v5.0.x (TST: Un-xfail test_iers_a_dl_mirror)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

datacenter.iers.org SSL: CERTIFICATE_VERIFY_FAILED (Column year failed to convert: invalid literal for int() with base 10: '<!')

2 participants