Skip to content

TST: Test against dev infrastructure weekly, add scipy dev to devdeps#13080

Merged
pllim merged 2 commits intoastropy:mainfrom
pllim:infra-weekly-devdeps
Jul 1, 2022
Merged

TST: Test against dev infrastructure weekly, add scipy dev to devdeps#13080
pllim merged 2 commits intoastropy:mainfrom
pllim:infra-weekly-devdeps

Conversation

@pllim
Copy link
Member

@pllim pllim commented Apr 7, 2022 •
edited
Loading

Description

This pull request is to test against dev versions of infrastructure packages as discussed in #12853 (comment) . I try to cover the usual suspects that we can control.

Pro: We catch breakage from our infrastructure packages before they are released. Given that most of them are low-traffic, weekly should be enough without affecting PR CI jobs.

Con: We won't catch breakage soon enough. Someone needs to check the cron jobs weekly (who is going to check it when I am away?).

Out of scope:

  • Dev Sphinx stuff for doc build.
  • Include dev version of every possible thing we use in a test job.
  • Check the logs carefully to make sure intended versions are actually installed.

devinfra (this PR, weekly)

Numpy: 1.23.0
Scipy: not available
Matplotlib: 3.5.2
h5py: not available
Pandas: not available
PyERFA: 2.0.0.1
Cython: not available
Scikit-image: not available
asdf: not available
pyarrow: not available

Using Astropy options: remote_data: none.

plugins: doctestplus-0.12.1.dev3+g64d38f2, mock-3.8.1, astropy-0.10.1.dev3+gf64de38, forked-1.4.0, openfiles-0.5.1.dev18+g2bc5b0f, mpl-0.16.1.dev3+g48e652f, cov-3.0.0, xdist-2.5.0, arraydiff-0.5.1.dev13+ga74f2e3, astropy-header-0.2.2.dev10+gf57bdc8, hypothesis-6.46.7, remotedata-0.3.4.dev2+g3e82525, filter-subpackage-0.1.2.dev11+gaacb510

devdeps (weekly)

Numpy: 1.24.0.dev0+427.gf9bed20bf
Scipy: 1.10.0.dev0+0.df3fe4e
Matplotlib: 3.6.0.dev2618+g9fb42c9d5
h5py: not available
Pandas: not available
PyERFA: 2.0.0.2.dev7+gc23e4df
Cython: not available
Scikit-image: not available
asdf: 2.12.1.dev58+ge0a6081
pyarrow: not available

Using Astropy options: remote_data: none.

plugins: asdf-2.12.1.dev58+ge0a6081, mock-3.8.1, forked-1.4.0, astropy-header-0.2.1, cov-3.0.0, xdist-2.5.0, openfiles-0.5.0, arraydiff-0.5.0, filter-subpackage-0.1.1, hypothesis-6.46.7, astropy-0.10.0, doctestplus-0.12.0, remotedata-0.3.3

devdeps (usual CI)

Numpy: 1.24.0.dev0+427.gf9bed20bf
Scipy: 1.10.0.dev0+0.df3fe4e
Matplotlib: 3.6.0.dev2618+g9fb42c9d5
h5py: not available
Pandas: not available
PyERFA: 2.0.0.2.dev7+gc23e4df
Cython: not available
Scikit-image: not available
asdf: 2.12.1.dev58+ge0a6081
pyarrow: not available

Using Astropy options: remote_data: any.

plugins: asdf-2.12.1.dev58+ge0a6081, mock-3.8.1, forked-1.4.0, astropy-header-0.2.1, cov-3.0.0, xdist-2.5.0, openfiles-0.5.0, arraydiff-0.5.0, filter-subpackage-0.1.1, hypothesis-6.46.7, astropy-0.10.0, doctestplus-0.12.0, remotedata-0.3.3

alldeps (usual CI)

Numpy: 1.23.0
Scipy: 1.8.1
Matplotlib: 3.5.1
h5py: 3.7.0
Pandas: 1.4.3
PyERFA: 2.0.0.1
Cython: not available
Scikit-image: not available
asdf: 2.12.0
pyarrow: 8.0.0

Using Astropy options: remote_data: none.

plugins: mock-3.8.1, forked-1.4.0, astropy-header-0.2.1, cov-3.0.0, xdist-2.5.0, arraydiff-0.5.0, filter-subpackage-0.1.1, hypothesis-6.46.7, astropy-0.10.0, doctestplus-0.12.0, remotedata-0.3.3, asdf-2.12.0, openfiles-0.4.0

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the Extra CI label.
  • Is a change log needed? If yes, did the change log check pass? If no, add the no-changelog-entry-needed label. If this is a manual backport, use the skip-changelog-checks label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but astropy-bot check might be missing; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate backport-X.Y.x label(s) before merge.

@pllim pllim added this to the v5.1 milestone Apr 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2022

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@pllim pllim mentioned this pull request Apr 7, 2022
Closed
10 tasks
@pllim pllim added the Extra CI Run cron CI as part of PR label Apr 7, 2022
@pllim

This comment was marked as outdated.

Sign in to view
@pllim pllim marked this pull request as ready for review April 7, 2022 22:56
@pllim pllim requested a review from a team April 7, 2022 22:57
@pllim pllim force-pushed the infra-weekly-devdeps branch from 2a27e95 to bdc8008 Compare April 21, 2022 17:27
@pllim
Copy link
Member Author

pllim commented Apr 21, 2022

This is not critical for v5.1, so moving milestone.

@pllim pllim modified the milestones: v5.1, v5.2 Apr 21, 2022
@pllim pllim force-pushed the infra-weekly-devdeps branch from bdc8008 to e0b7b9c Compare June 17, 2022 14:10
pllim
pllim commented Jun 30, 2022
View reviewed changes
@pllim pllim force-pushed the infra-weekly-devdeps branch from e0b7b9c to c078bfe Compare June 30, 2022 17:48
@pllim
TST: Separate devdeps and devinfra jobs.
313e06a 
TST: Add scipy dev to devdeps
@pllim pllim changed the title TST: Test against dev infrastructure weekly TST: Test against dev infrastructure weekly, add scipy dev to devdeps Jun 30, 2022
@pllim
Copy link
Member Author

pllim commented Jun 30, 2022

As discussed on 2022-06-30 tag-up, I separated out devinfra from devdeps job.

Also unrelated but might as well: Add scipy dev to avoid future occurences of #13400 .

cc @WilliamJamieson and @saimn

saimn
saimn reviewed Jun 30, 2022
View reviewed changes
@pllim
Copy link
Member Author

pllim commented Jun 30, 2022

I cancelled the exotic CI jobs as they are irrelevant.

@pllim
Copy link
Member Author

pllim commented Jun 30, 2022

Linkcheck failure is unrelated but matplotlib wheel doesn't seem to work, @saimn , did I set it up wrong?

https://github.com/astropy/astropy/runs/7139527444?check_suite_focus=true

@pllim
Copy link
Member Author

pllim commented Jun 30, 2022

I don't know what's up with the matplotlib wheel but it is too painful to install. I am going to revert back to installing it from source.

@pllim pllim force-pushed the infra-weekly-devdeps branch from 2a1f3a7 to 313e06a Compare June 30, 2022 22:40
@pllim
Copy link
Member Author

pllim commented Jul 1, 2022

@saimn or @WilliamJamieson , do you want one last look before I merge?

@pllim
Copy link
Member Author

pllim commented Jul 1, 2022

#yolo

@pllim pllim merged commit 133ef22 into astropy:main Jul 1, 2022
@pllim pllim deleted the infra-weekly-devdeps branch July 1, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saimn saimn saimn left review comments

Assignees

No one assigned

Labels

Extra CI Run cron CI as part of PR no-changelog-entry-needed testing

Projects

None yet

Milestone

v5.2

Development

Successfully merging this pull request may close these issues.

2 participants

@pllim @saimn