Skip to content

readded maia.usno.navy.mil as an option for iers A data - #13004

Merged
pllim merged 2 commits into
astropy:mainfrom
malynda:re-add-usno-iers-url
Mar 29, 2022
Merged

readded maia.usno.navy.mil as an option for iers A data#13004
pllim merged 2 commits into
astropy:mainfrom
malynda:re-add-usno-iers-url

Conversation

@malynda

@malynda malynda commented Mar 28, 2022 •
edited by pllim
Loading

Copy link
Copy Markdown
Contributor

Description

re-added maia url as a 3rd option rather than replacing the two existing options, added to the front of the list for iers_a download sources as the others are currently experiencing issues.

Fixes #12777

Works around #12998

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the Extra CI label.
  • Is a change log needed? If yes, did the change log check pass? If no, add the no-changelog-entry-needed label. If this is a manual backport, use the skip-changelog-checks label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but astropy-bot check might be missing; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate backport-X.Y.x label(s) before merge.

github-actions[bot]
github-actions Bot reviewed Mar 28, 2022
View reviewed changes

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Astropy 👋 and congratulations on your first pull request! 🎉

A project member will respond to you as soon as possible; in the meantime, please have a look over the Checklist for Contributed Code and make sure you've addressed as many of the questions there as possible.

If you feel that this pull request has not been responded to in a timely manner, please leave a comment mentioning our software support engineer @embray, or send a message directly to the development mailing list. If the issue is urgent or sensitive in nature (e.g., a security vulnerability) please send an e-mail directly to the private e-mail [email protected].

pllim
pllim reviewed Mar 28, 2022
View reviewed changes
Comment thread astropy/utils/iers/iers.py Resolved
pllim
pllim reviewed Mar 28, 2022
View reviewed changes
Comment thread docs/changes/utils/13004.update.rst Resolved
pllim
pllim reviewed Mar 28, 2022
View reviewed changes

@pllim pllim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need to revisit these issues:

@pllim pllim added this to the v5.0.4 milestone Mar 28, 2022
@pllim
pllim requested review from eteq and mhvk March 28, 2022 18:28
pllim
pllim reviewed Mar 28, 2022
View reviewed changes

@pllim pllim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please also squash into one commit?

Thank you soooo much for this patch!

Comment thread docs/changes/utils/13004.other.rst Resolved
@pllim

This comment was marked as resolved.

Sign in to view
@malynda
malynda force-pushed the re-add-usno-iers-url branch from d3427bb to cea3866 Compare March 28, 2022 19:36
@pllim

pllim commented Mar 28, 2022

Copy link
Copy Markdown
Member 
Fix End of Files.........................................................Failed
- hook id: end-of-file-fixer
- duration: 0.06s
- exit code: 1
- files were modified by this hook

Maybe the CI wants a blank line in L2 in the change log file?

While you are at it, can you please change it from "bugfix" to "api" and squash again? Thanks! 🙏

@mhvk

mhvk commented Mar 28, 2022

Copy link
Copy Markdown
Contributor

Thanks very much also from me -- a small change but really helpful!!

@malynda
malynda force-pushed the re-add-usno-iers-url branch from cea3866 to d7c2f6c Compare March 28, 2022 19:51
@malynda

malynda commented Mar 28, 2022

Copy link
Copy Markdown
Contributor Author 
Fix End of Files.........................................................Failed
- hook id: end-of-file-fixer
- duration: 0.06s
- exit code: 1
- files were modified by this hook

Maybe the CI wants a blank line in L2 in the change log file?

While you are at it, can you please change it from "bugfix" to "api" and squash again? Thanks! 🙏

Yep, it wanted the blank line.

@pllim

pllim commented Mar 28, 2022

Copy link
Copy Markdown
Member

test_iers_a_dl_mirror() failed because the mirror is broken... Do you think we should move that FTP site as mirror and forget about iers.org for a while? 👀

@mhvk

mhvk commented Mar 28, 2022

Copy link
Copy Markdown
Contributor

I'd be happy to skip that test for now, get things working, and then implement a system where a whole list of entries get tried.

@pllim

pllim commented Mar 28, 2022

Copy link
Copy Markdown
Member

I pushed a commit directly to this PR to xfail the test. If the site ever gets fixed, it will xpass and we will know. FYI.

@pllim pllim added the zzz 💤 merge-when-ci-passes Do not use: We have auto-merge option now. label Mar 28, 2022
pllim
pllim approved these changes Mar 28, 2022
View reviewed changes

@pllim pllim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for your help and patience, @malynda !

@pllim pllim mentioned this pull request Mar 28, 2022
Closed
@pllim

pllim commented Mar 28, 2022

Copy link
Copy Markdown
Member

astropy/visualization/wcsaxes/core.py:docstring of astropy.visualization.wcsaxes.core.WCSAxes.get_tightbbox:48: WARNING: py:obj reference target not found: matplotlib.spines.Spine.get_window_extent

Wut? Why? flips table

@pllim

pllim commented Mar 28, 2022

Copy link
Copy Markdown
Member

not sure why RTD taking so long...

@pllim
pllim merged commit 243bad7 into astropy:main Mar 29, 2022
@pllim

pllim commented Mar 29, 2022

Copy link
Copy Markdown
Member

Merged. Thanks!

meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Mar 29, 2022
@pllim @meeseeksmachine
Backport PR astropy#13004: readded maia.usno.navy.mil as an option fo…
0a0660e 
…r iers A data
@meeseeksmachine meeseeksmachine mentioned this pull request Mar 29, 2022
Merged
@malynda
malynda deleted the re-add-usno-iers-url branch March 29, 2022 11:47
@mexanick mexanick mentioned this pull request Mar 29, 2022
Closed
@pllim pllim mentioned this pull request Mar 29, 2022
Closed
pllim added a commit that referenced this pull request Mar 29, 2022
@pllim
Merge pull request #13006 from meeseeksmachine/auto-backport-of-pr-13…
47d03b7 
…004-on-v5.0.x

Backport PR #13004 on branch v5.0.x (readded maia.usno.navy.mil as an option for iers A data)
@SeiyaNozaki SeiyaNozaki mentioned this pull request Apr 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments
@pllim pllim pllim approved these changes
@mhvk mhvk Awaiting requested review from mhvk
@eteq eteq Awaiting requested review from eteq

Assignees

No one assigned

Labels

🔥 Critical utils.iers zzz 💤 merge-when-ci-passes Do not use: We have auto-merge option now.

Projects

None yet

Milestone

v5.0.4

Development

Successfully merging this pull request may close these issues.

USNO IERS services are back online, but do we still care?

3 participants

@malynda @pllim @mhvk