Skip to content

Backport PR #12855 on branch v5.0.x (TST: Fix pyinstaller CI job)#12871

Merged
pllim merged 1 commit intoastropy:v5.0.xfrom
pllim:manual-backport-pr12855-v5.0.x
Feb 17, 2022
Merged

Backport PR #12855 on branch v5.0.x (TST: Fix pyinstaller CI job)#12871
pllim merged 1 commit intoastropy:v5.0.xfrom
pllim:manual-backport-pr12855-v5.0.x

Conversation

@pllim
Copy link
Member

@pllim pllim commented Feb 17, 2022

Description

This pull request is a manual backport of #12855

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the Extra CI label.
  • Is a change log needed? If yes, did the change log check pass? If no, add the no-changelog-entry-needed label. If this is a manual backport, use the skip-changelog-checks label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but astropy-bot check might be missing; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate backport-X.Y.x label(s) before merge.

@pllim pllim added the skip-basebranch-check Skip base branch check for direct backports label Feb 17, 2022
@pllim pllim added this to the v5.0.2 milestone Feb 17, 2022
@pllim
Copy link
Member Author

pllim commented Feb 17, 2022

Just need the pyinstaller job to pass. 🤞

@pllim pllim merged commit 0718f3e into astropy:v5.0.x Feb 17, 2022
@pllim pllim deleted the manual-backport-pr12855-v5.0.x branch February 17, 2022 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog-entry-needed skip-basebranch-check Skip base branch check for direct backports testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant