Skip to content

BUG: don't escalate a deprecation warning from numpy into an ImportError. Partially revert #12655#12867

Merged
pllim merged 1 commit intoastropy:mainfrom
neutrinoceros:hotfix_12865
Feb 17, 2022
Merged

BUG: don't escalate a deprecation warning from numpy into an ImportError. Partially revert #12655#12867
pllim merged 1 commit intoastropy:mainfrom
neutrinoceros:hotfix_12865

Conversation

@neutrinoceros
Copy link
Contributor

@neutrinoceros neutrinoceros commented Feb 17, 2022

Description

Fixes #12865

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the Extra CI label.
  • Is a change log needed? If yes, did the change log check pass? If no, add the no-changelog-entry-needed label. If this is a manual backport, use the skip-changelog-checks label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but astropy-bot check might be missing; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate backport-X.Y.x label(s) before merge.

@saimn
Copy link
Contributor

saimn commented Feb 17, 2022

Ref #12655 and #12157

@pllim pllim added the Bug label Feb 17, 2022
Copy link
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ops, my bad. Thanks for the fix!

@saimn
Copy link
Contributor

saimn commented Feb 17, 2022

Thanks @neutrinoceros !

@neutrinoceros neutrinoceros deleted the hotfix_12865 branch February 17, 2022 18:52
@pllim
Copy link
Member

pllim commented Feb 17, 2022

@meeseeksdev backport to v5.0.x

saimn added a commit that referenced this pull request Feb 17, 2022
…867-on-v5.0.x

Backport PR #12867 on branch v5.0.x (BUG: don't escalate a deprecation warning from numpy into an ImportError. Partially revert #12655)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Astropy's lazy loading mechanism doesn't survive deprecation warnings

3 participants