Skip to content

TST: Fix pyinstaller CI job#12855

Merged
astrofrog merged 3 commits intoastropy:mainfrom
pllim:pyinstaller-no-hide-failure
Feb 17, 2022
Merged

TST: Fix pyinstaller CI job#12855
astrofrog merged 3 commits intoastropy:mainfrom
pllim:pyinstaller-no-hide-failure

Conversation

@pllim
Copy link
Member

@pllim pllim commented Feb 15, 2022 •
edited by astrofrog
Loading

Description

This pull request is to follow advice at #12837 (comment) .

Also see:

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the Extra CI label.
  • Is a change log needed? If yes, did the change log check pass? If no, add the no-changelog-entry-needed label. If this is a manual backport, use the skip-changelog-checks label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but astropy-bot check might be missing; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate backport-X.Y.x label(s) before merge.

@pllim pllim added this to the v5.0.2 milestone Feb 15, 2022
@pllim pllim added the Extra CI Run cron CI as part of PR label Feb 15, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 15, 2022

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@pllim
Copy link
Member Author

pllim commented Feb 15, 2022

I'll cancel everything but pyinstaller job for now.

@pllim

This comment was marked as resolved.

Sign in to view
@pllim pllim added the Upstream Action Required Was: Upstream Fix Required label Feb 15, 2022
@EfremBraun
Copy link

EfremBraun commented Feb 15, 2022

See pyinstaller/pyinstaller-hooks-contrib#379 (comment). metadata for astropy is needed (seemingly) as well.

@pllim
Copy link
Member Author

pllim commented Feb 16, 2022 •
edited
Loading

@bwoodsend , is the CI expected to pick up the new pyinstaller release immediately or should I wait a little bit? Thanks!

Re: pyinstaller/pyinstaller-hooks-contrib#381 (comment)

@bwoodsend
Copy link
Contributor

bwoodsend commented Feb 16, 2022

It's not pyinstaller - it's the hooks repo (pyinstaller-hooks-contrib). But yes, it's on PyPI so fire away.

@bwoodsend
Copy link
Contributor

bwoodsend commented Feb 16, 2022

This failure has nothing to do with numpy's metadata though so unless you've addressed that elsewhere it'll still fail in exactly the same place.

@pllim
Copy link
Member Author

pllim commented Feb 16, 2022

What does this mean?

py/_vendored_packages/apipkg/__init__.py:75: in importobj
    ???
E   ModuleNotFoundError: No module named 'py._code'

@bwoodsend
Copy link
Contributor

bwoodsend commented Feb 16, 2022

I suppose in the short term it means add --collect-submodules=py here. We'll need to fix that our end too.

pllim and others added 2 commits February 16, 2022 16:46
@pllim
TST: Do not use metadata.version numpy
793fc21 
because it hides real pyinstaller failures.

Remove pytest-mpl from pyinstaller job script to avoid error.
@pllim @bwoodsend
Collect submodule py to avoid module not found.
375562d 
Co-authored-by: Brénainn Woodsend <[email protected]>
@pllim pllim force-pushed the pyinstaller-no-hide-failure branch from a071b45 to 375562d Compare February 16, 2022 21:49
@pllim
Copy link
Member Author

pllim commented Feb 16, 2022

It passed. Thanks! 😸

@pllim pllim changed the title TST: Do not metadata.version numpy to expose real pyinstaller failures TST: Fix pyinstaller CI job Feb 16, 2022
@pllim pllim removed the Upstream Action Required Was: Upstream Fix Required label Feb 16, 2022
@pllim pllim requested a review from astrofrog February 16, 2022 22:10
@pllim pllim marked this pull request as ready for review February 16, 2022 22:10
@pllim
Copy link
Member Author

pllim commented Feb 16, 2022

Hmm... should I be more adventurous? Maybe I should see how much of these I can fix here too.

https://github.com/astropy/astropy/issues?q=is%3Aissue+is%3Aopen+pyinstaller

@bwoodsend
Copy link
Contributor

bwoodsend commented Feb 16, 2022

Both PyInstaller and NumPy have released fixes for the latest PyInstaller+NumPy issue so that one should work fine.

@astrofrog astrofrog merged commit 14fc84c into astropy:main Feb 17, 2022
@lumberbot-app
Copy link

lumberbot-app bot commented Feb 17, 2022

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v5.0.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -m1 14fc84c9c62d96e925e5764b4a178915245183ee
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #12855: TST: Fix pyinstaller CI job'
  1. Push to a named branch:
git push YOURFORK v5.0.x:auto-backport-of-pr-12855-on-v5.0.x
  1. Create a PR against branch v5.0.x, I would have named this PR:

"Backport PR #12855 on branch v5.0.x (TST: Fix pyinstaller CI job)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@pllim pllim deleted the pyinstaller-no-hide-failure branch February 17, 2022 17:57
pllim added a commit to pllim/astropy that referenced this pull request Feb 17, 2022
@pllim
MNT: Manual backport of astropy#12855
6d64aa4
@pllim pllim mentioned this pull request Feb 17, 2022
Merged
10 tasks
pllim added a commit that referenced this pull request Feb 17, 2022
@pllim
Merge pull request #12871 from pllim/manual-backport-pr12855-v5.0.x
0718f3e 
Backport PR #12855 on branch v5.0.x (TST: Fix pyinstaller CI job)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@astrofrog astrofrog astrofrog approved these changes

Assignees

No one assigned

Labels

Extra CI Run cron CI as part of PR no-changelog-entry-needed Ready-for-final-review testing

Projects

None yet

Milestone

v5.0.2

Development

Successfully merging this pull request may close these issues.

TST: pytest 7.0.0 broke pyinstaller job TST: Unpin numpy in pyinstaller job

4 participants

@pllim @EfremBraun @bwoodsend @astrofrog