Repository navigation
Add iterative wcs.all_world2pix - #1281
Conversation
Iterative inverse of wcs.all_pix2world. Closes astropy#1066.
There was a problem hiding this comment.
It might be worth making the tolerance a user-settable parameter which defaults to 1.e-6
|
This will be very useful, thanks! |
The name of this variable is meant to echo the name of the function, world2pix.
|
The only Travis failures occur in the configurations where the optional dependencies are disabled. As intended, these produce the error message: Anything else needed for this PR? |
|
@lpsinger - the tests that require scipy should be skipped for configurations where scipy is not installed. Check out how the tests in astropy.cosmology do it. At the end of the day, all configurations should pass. |
Ah, of course. Fixed now. |
|
@mdboom - just bringing this issue to your attention in case you can review it. |
There was a problem hiding this comment.
Minor nit. We should have a blank line before the beginning of a new method.
|
👍 |
|
Any other requests, or is someone ready to merge this? |
Add iterative wcs.all_world2pix
|
I just merged this, and then realised too late that this should probably have an entry in whatsnew. It's a pretty major (and very useful) new feature and should be highlighted. |
Thank you, it's nice of you to say so. I'll start a whatsnew patch; let me know if you are already on this. |
|
Nope -- I was hoping you would write the entry if you can... |
|
Please also add a changelog entry for this if you could. |
|
Done. |
@iguananaut, see #1307. |
Iterative inverse of wcs.all_pix2world. Closes #1066.
I also have a unit test in the works using some of the PTF example files that are already in
astropy/astropy/wcs/tests/data, but my tests rely on #299/#1278.