Skip to content

Manual backport of non-controversial parts from #12633 - #12795

Merged
astrofrog merged 1 commit into
astropy:v5.0.xfrom
pllim:pyinstaller-ugh
Jan 26, 2022
Merged

astrofrog merged 1 commit into
astropy:v5.0.xfrom
pllim:pyinstaller-ugh

Conversation

@pllim

@pllim pllim commented Jan 26, 2022 •

Copy link
Copy Markdown
Member

Description

This pull request is to manually backport part of #12633 because Tom said that PR fixes pyinstaller build. 🤷

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the Extra CI label.
  • Is a change log needed? If yes, did the change log check pass? If no, add the no-changelog-entry-needed label. If this is a manual backport, use the skip-changelog-checks label unless special changelog handling is necessary.
  • Is a milestone set? Milestone must be set but astropy-bot check might be missing; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate backport-X.Y.x label(s) before merge.

@github-actions

Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@pllim

pllim commented Jan 26, 2022

Copy link
Copy Markdown
Member Author

Oh my gerd... it passed. I still don't understand why but I'll take it.

@pllim
pllim requested a review from astrofrog January 26, 2022 20:23
@pllim
pllim marked this pull request as ready for review January 26, 2022 20:23

@astrofrog astrofrog left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thanks!

@astrofrog
astrofrog merged commit 3772bef into astropy:v5.0.x Jan 26, 2022
@pllim
pllim deleted the pyinstaller-ugh branch January 26, 2022 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants