Skip to content

Fix changelog fragment type for #12492 - #12772

Merged
mhvk merged 1 commit into
astropy:mainfrom
astrofrog:fix-12492-fragment
Jan 22, 2022
Merged

mhvk merged 1 commit into
astropy:mainfrom
astrofrog:fix-12492-fragment

Conversation

@astrofrog

@astrofrog astrofrog commented Jan 22, 2022 •

Copy link
Copy Markdown
Member

Description

Based on discussion in #12492, that PR should be treated as a bug fix and not a new feature.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the Extra CI label.
  • Is a change log needed? If yes, did the change log check pass? If no, add the no-changelog-entry-needed label. If this is a manual backport, use the skip-changelog-checks label unless special changelog handling is necessary.
  • Is a milestone set? Milestone must be set but astropy-bot check might be missing; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate backport-X.Y.x label(s) before merge.

@astrofrog astrofrog added the skip-changelog-checks Tells bot to skip changlog checks label Jan 22, 2022
@astrofrog astrofrog added this to the v5.0.1 milestone Jan 22, 2022
@github-actions github-actions Bot added the units label Jan 22, 2022
@pllim
pllim requested review from mhvk and nstarman January 22, 2022 01:14

@mhvk mhvk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @astrofrog! I see in #12492 that @nstarman indeed mentioned the fragment should be renamed, but I didn't actually do it...

@mhvk
mhvk merged commit a3395c7 into astropy:main Jan 22, 2022
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Jan 22, 2022
pllim added a commit that referenced this pull request Jan 22, 2022
…772-on-v5.0.x

Backport PR #12772 on branch v5.0.x (Fix changelog fragment type for #12492)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog-checks Tells bot to skip changlog checks units

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants