Skip to content

TST: Use NPY_DISABLE_CPU_FEATURES for numpy 1.22 (try 2)#12685

Closed
pllim wants to merge 4 commits intoastropy:mainfrom
pllim:and-we-will-all-float-on-okay-2
Closed

TST: Use NPY_DISABLE_CPU_FEATURES for numpy 1.22 (try 2)#12685
pllim wants to merge 4 commits intoastropy:mainfrom
pllim:and-we-will-all-float-on-okay-2

Conversation

@pllim
Copy link
Member

@pllim pllim commented Jan 4, 2022

Description

Like #12684 but with most minimal fix possible.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the Extra CI label.
  • Is a change log needed? If yes, did the change log check pass? If no, add the no-changelog-entry-needed label. If this is a manual backport, use the skip-changelog-checks label unless special changelog handling is necessary.
  • Is a milestone set? Milestone must be set but astropy-bot check might be missing; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate backport-X.Y.x label(s) before merge.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2022

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@pllim
Copy link
Member Author

pllim commented Jan 4, 2022

If we pick this, we will have to revert astropy/astropy-data@84deb2c 😆 😭

@pllim
Copy link
Member Author

pllim commented Jan 4, 2022

Looks like it is working. Many thanks, @dstansby !

@pllim pllim closed this in #12682 Jan 5, 2022
@pllim pllim deleted the and-we-will-all-float-on-okay-2 branch January 5, 2022 18:38
@pllim
Copy link
Member Author

pllim commented Jan 5, 2022

@dstansby , after further discussions, we did decide to not use the env var because users probably won't set it and they might want to run the test suite on their own installations. Still, thank you very much for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant