TST: Use NPY_DISABLE_CPU_FEATURES for numpy 1.22 (try 2)#12685
Closed
pllim wants to merge 4 commits intoastropy:mainfrom
Closed
TST: Use NPY_DISABLE_CPU_FEATURES for numpy 1.22 (try 2)#12685pllim wants to merge 4 commits intoastropy:mainfrom
pllim wants to merge 4 commits intoastropy:mainfrom
Conversation
Contributor
|
👋 Thank you for your draft pull request! Do you know that you can use |
Member
Author
|
If we pick this, we will have to revert astropy/astropy-data@84deb2c 😆 😭 |
This was referenced Jan 4, 2022
Member
Author
|
Looks like it is working. Many thanks, @dstansby ! |
Member
Author
|
@dstansby , after further discussions, we did decide to not use the env var because users probably won't set it and they might want to run the test suite on their own installations. Still, thank you very much for your help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Like #12684 but with most minimal fix possible.
Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
Extra CIlabel.no-changelog-entry-neededlabel. If this is a manual backport, use theskip-changelog-checkslabel unless special changelog handling is necessary.astropy-botcheck might be missing; do not let the green checkmark fool you.backport-X.Y.xlabel(s) before merge.