MNT: Remove all mention of distutils#12655
Merged
pllim merged 1 commit intoastropy:mainfrom Dec 29, 2021
Merged
Conversation
Contributor
|
👋 Thank you for your draft pull request! Do you know that you can use |
Member
Author
|
Interesting... I thought CI would break more spectacularly. |
mhvk
approved these changes
Dec 28, 2021
Contributor
mhvk
left a comment
mhvk
left a comment
There was a problem hiding this comment.
Indeed, great to see what seem no related failures: the aarch64 error definitely seems unrelated, as does the -dev (just a(nother) timeout...). So, I see no reason not just to get this in!
Member
Author
|
Thanks for the review, @mhvk ! I just merged another PR that would hopefully fixed all the CI (except for timeouts), so I rebased here and see if things will be better... 🤞 |
meeseeksmachine
pushed a commit
to meeseeksmachine/astropy
that referenced
this pull request
Dec 29, 2021
Contributor
|
Nice cleanup! Thanks, @pllim! |
pllim
added a commit
that referenced
this pull request
Dec 29, 2021
…655-on-v5.0.x Backport PR #12655 on branch v5.0.x (MNT: Remove all mention of distutils)
This was referenced Jan 2, 2022
pllim
added a commit
to mhvk/astropy
that referenced
this pull request
Jan 3, 2022
because without it, pyinstaller crashes again though it was fine during that PR.
pllim
added a commit
to mhvk/astropy
that referenced
this pull request
Jan 3, 2022
This reverts commit 540fa73.
pllim
added a commit
to pllim/astropy
that referenced
this pull request
Jan 4, 2022
which undo a bit of astropy#12655
neutrinoceros
added a commit
to neutrinoceros/astropy
that referenced
this pull request
Feb 17, 2022
…ror. Partially revert astropy#12655
10 tasks
pllim
added a commit
that referenced
this pull request
Feb 17, 2022
BUG: don't escalate a deprecation warning from numpy into an ImportError. Partially revert #12655
meeseeksmachine
pushed a commit
to meeseeksmachine/astropy
that referenced
this pull request
Feb 17, 2022
…from numpy into an ImportError. Partially revert astropy#12655
This was referenced Feb 17, 2022
nstarman
pushed a commit
to nstarman/astropy
that referenced
this pull request
Feb 18, 2022
…ror. Partially revert astropy#12655
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request is to remove all mention of
distutilsbecause it is deprecated.I don't think this needs a change log?
Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
Extra CIlabel.no-changelog-entry-neededlabel. If this is a manual backport, use theskip-changelog-checkslabel unless special changelog handling is necessary.astropy-botcheck might be missing; do not let the green checkmark fool you.backport-X.Y.xlabel(s) before merge.