Skip to content

Remove dependency on deprecated distutils.version.StrictVersion#12649

Merged
mhvk merged 2 commits intoastropy:mainfrom
mhvk:io-votable-remove-dependency-on-distutils
Dec 28, 2021
Merged

Remove dependency on deprecated distutils.version.StrictVersion#12649
mhvk merged 2 commits intoastropy:mainfrom
mhvk:io-votable-remove-dependency-on-distutils

Conversation

@mhvk
Copy link
Contributor

@mhvk mhvk commented Dec 28, 2021

All builds are failing because of a new deprecation message from distutils. In this particular case, just substituting packaging.version.Version for distutils.version.StrictVersion seemed an easy win, especially since one should not generally be strict on input.

Even if people disagree, however, I would suggest to merge this first (if tests pass) and argue later...

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the Extra CI label.
  • Is a change log needed? If yes, did the change log check pass? If no, add the no-changelog-entry-needed label. If this is a manual backport, use the skip-changelog-checks label unless special changelog handling is necessary.
  • Is a milestone set? Milestone must be set but astropy-bot check might be missing; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate backport-X.Y.x label(s) before merge.

@mhvk
Copy link
Contributor Author

mhvk commented Dec 28, 2021

@nstarman - as someone who seemed to be on-line right now, maybe you can have a look too. Would be good to not have all tests fail!

Copy link
Member

@nstarman nstarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Edit: looks like there's a missing distutils replacement for Mac checks in fits.

@nstarman nstarman added the zzz 💤 merge-when-ci-passes Do not use: We have auto-merge option now. label Dec 28, 2021
Copy link
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@pllim
Copy link
Member

pllim commented Dec 28, 2021

Oh yeah... CI is failing.

Copy link
Contributor Author

@mhvk mhvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha, @pllim, just saw the failure too, but you were ahead of me! Great! In another PR, we probably should also address astropy/version.py...

@mhvk
Copy link
Contributor Author

mhvk commented Dec 28, 2021

OK, now tests pass so I'll merge this. I raised #12650 to remind us about remaining cleanup.

@mhvk mhvk merged commit 689f9d3 into astropy:main Dec 28, 2021
@mhvk mhvk deleted the io-votable-remove-dependency-on-distutils branch December 28, 2021 21:22
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Dec 28, 2021
@pllim
Copy link
Member

pllim commented Dec 28, 2021

@meeseeksdev backport to v5.0.x

pllim added a commit that referenced this pull request Dec 28, 2021
…649-on-v5.0.x

Backport PR #12649 on branch v5.0.x (Remove dependency on deprecated distutils.version.StrictVersion)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants