Remove dependency on deprecated distutils.version.StrictVersion#12649
Merged
mhvk merged 2 commits intoastropy:mainfrom Dec 28, 2021
Merged
Remove dependency on deprecated distutils.version.StrictVersion#12649mhvk merged 2 commits intoastropy:mainfrom
mhvk merged 2 commits intoastropy:mainfrom
Conversation
Contributor
Author
|
@nstarman - as someone who seemed to be on-line right now, maybe you can have a look too. Would be good to not have all tests fail! |
nstarman
approved these changes
Dec 28, 2021
Member
|
Oh yeah... CI is failing. |
Contributor
Author
|
OK, now tests pass so I'll merge this. I raised #12650 to remind us about remaining cleanup. |
meeseeksmachine
pushed a commit
to meeseeksmachine/astropy
that referenced
this pull request
Dec 28, 2021
…version.StrictVersion
Member
|
@meeseeksdev backport to v5.0.x |
pllim
added a commit
that referenced
this pull request
Dec 28, 2021
…649-on-v5.0.x Backport PR #12649 on branch v5.0.x (Remove dependency on deprecated distutils.version.StrictVersion)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All builds are failing because of a new deprecation message from distutils. In this particular case, just substituting
packaging.version.Versionfordistutils.version.StrictVersionseemed an easy win, especially since one should not generally be strict on input.Even if people disagree, however, I would suggest to merge this first (if tests pass) and argue later...
Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
Extra CIlabel.no-changelog-entry-neededlabel. If this is a manual backport, use theskip-changelog-checkslabel unless special changelog handling is necessary.astropy-botcheck might be missing; do not let the green checkmark fool you.backport-X.Y.xlabel(s) before merge.