Skip to content

TST: Attempt to fix CI - #12642

Closed
pllim wants to merge 3 commits into
astropy:mainfrom
pllim:fix-ci-mystery-error
Closed

pllim wants to merge 3 commits into
astropy:mainfrom
pllim:fix-ci-mystery-error

Conversation

@pllim

@pllim pllim commented Dec 27, 2021 •

Copy link
Copy Markdown
Member

Description

This pull request is an attempt to fix CI that started failing. The timing coincided with new pytest-astropy-header 0.2.0 release.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the Extra CI label.
  • Is a change log needed? If yes, did the change log check pass? If no, add the no-changelog-entry-needed label. If this is a manual backport, use the skip-changelog-checks label unless special changelog handling is necessary.
  • Is a milestone set? Milestone must be set but astropy-bot check might be missing; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate backport-X.Y.x label(s) before merge.

Localize __version__ import in conftest.py
@github-actions

Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@pllim pllim mentioned this pull request Dec 27, 2021
10 tasks done
@pllim

pllim commented Dec 27, 2021

Copy link
Copy Markdown
Member Author

Nope. I'll need expert advice over at astropy/pytest-astropy-header#41

@pllim pllim closed this Dec 27, 2021
@pllim
pllim deleted the fix-ci-mystery-error branch December 27, 2021 21:58
@eerovaher eerovaher mentioned this pull request Jan 21, 2022
8 of 9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant