Repository navigation
Temporary fix problems with Quantity.__class_getitem__ - #12511
Merged
nstarman merged 2 commits intoNov 22, 2021
Merged
Conversation
mhvk
force-pushed
the
temporary-fix-for-numpy-dev-typing-error
branch
from
November 21, 2021 20:46
3acfeb0 to
17e281e
Compare
Contributor
Author
|
Hmm, looks like there are other numpy-dev problems too... Sigh. |
Member
|
I can take a look at this later tonight. |
mhvk
force-pushed
the
temporary-fix-for-numpy-dev-typing-error
branch
from
November 22, 2021 00:36
0857e9f to
997417c
Compare
Contributor
Author
|
OK, added a commit to fix the other numpy-dev problems... |
Contributor
Author
|
OK, looks like all tests now pass again, which will help unblock everything else. Given that, cc @pllim... |
nstarman
approved these changes
Nov 22, 2021
nstarman
left a comment
nstarman
left a comment
Member
There was a problem hiding this comment.
The NDArray.__class_getitem__ looks good to me.
This was referenced Nov 22, 2021
Merged
Member
|
Thanks! Is there a follow-up issue for a proper fix? Update: I found #12510 |
Member
|
@meeseeksdev backport to v5.0.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/astropy
that referenced
this pull request
Nov 22, 2021
Member
|
For future reference, when you intend to merge a PR milestoned for v5.0.x, please also add a |
pllim
added a commit
that referenced
this pull request
Nov 22, 2021
…511-on-v5.0.x Backport PR #12511 on branch v5.0.x (Temporary fix problems with Quantity.__class_getitem__)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not a permanent fix, but we need to get the tests running again!
EDIT: also include a fix for
Maskedno longer working withnp.quantile.