Repository navigation
register structured units with yaml serialization - #12492
Merged
Merged
Conversation
Co-authored-by: Marten van Kerkwijk <[email protected]> Signed-off-by: Nathaniel Starkman (@nstarman) <[email protected]>
nstarman
force-pushed
the
units-structured-to-yaml
branch
from
November 18, 2021 06:24
ad354b5 to
a58cad0
Compare
mhvk
approved these changes
Nov 18, 2021
mhvk
left a comment
Contributor
There was a problem hiding this comment.
Looks good! The failures are unrelated, so approved! The numpy.void issue seems separate, as Quantity((1., 2.), dtype='f8,f8', unit=u.m) fails too. Would you mind raising a separate issue for it?
Contributor
|
Damn, why do I think about this only after merging? Isn't this really a bugfix? |
Member
Author
|
I suppose it is. Backport? |
Member
Author
|
I suppose that also requires changing the changelog fragment to a bug fix |
Contributor
|
@meeseeksdev backport to v5.0.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/astropy
that referenced
this pull request
Dec 3, 2021
mhvk
added a commit
that referenced
this pull request
Dec 3, 2021
…492-on-v5.0.x Backport PR #12492 on branch v5.0.x (register structured units with yaml serialization)
Member
|
For the record, the news fragment of this should have been updated to be of type 'bugfix' - I'll make the change for this one. |
9 tasks
Member
Author
|
Thanks! |
astrofrog
added a commit
to astrofrog/astropy
that referenced
this pull request
Jan 22, 2022
7 of 9 tasks
mhvk
added a commit
that referenced
this pull request
Jan 22, 2022
Fix changelog fragment type for #12492
meeseeksmachine
pushed a commit
to meeseeksmachine/astropy
that referenced
this pull request
Jan 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the structured unit serialization.
Doing the same for a
numpy.voidwill take a separate commit.The following work
This does not
Fixes #12485
Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
Extra CIlabel.no-changelog-entry-neededlabel. If this is a manual backport, use theskip-changelog-checkslabel unless special changelog handling is necessary.astropy-botcheck might be missing; do not let the green checkmark fool you.backport-X.Y.xlabel(s) before merge.