Skip to content

fix bug where redshift not recognized as unit - #12390

Merged
nstarman merged 1 commit into
astropy:mainfrom
nstarman:cosmo-bugfix-yaml-redshift
Nov 4, 2021
Merged

nstarman merged 1 commit into
astropy:mainfrom
nstarman:cosmo-bugfix-yaml-redshift

Conversation

@nstarman

@nstarman nstarman commented Nov 3, 2021 •

Copy link
Copy Markdown
Member

Signed-off-by: Nathaniel Starkman (@nstarman) [email protected]

PR #12190 and #12279 independently passed CI and had no merge conflicts. But put together...

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the Extra CI label.
  • Is a change log needed? If yes, did the change log check pass? If no, add the no-changelog-entry-needed label. If this is a manual backport, use the skip-changelog-checks label unless special changelog handling is necessary.
  • Is a milestone set? Milestone must be set but astropy-bot check might be missing; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate backport-X.Y.x label(s) before merge.

@nstarman nstarman added this to the v5.1 milestone Nov 3, 2021
@nstarman
nstarman requested a review from mhvk November 3, 2021 23:39
@nstarman nstarman mentioned this pull request Nov 3, 2021
9 tasks done

@mhvk mhvk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes, that can happen... Looks good! Merge if tests pass...

@mhvk mhvk added the zzz 💤 merge-when-ci-passes Do not use: We have auto-merge option now. label Nov 3, 2021
@nstarman
nstarman merged commit 732044e into astropy:main Nov 4, 2021
@nstarman
nstarman deleted the cosmo-bugfix-yaml-redshift branch November 4, 2021 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants