Skip to content

Ignore memory policy warning#12331

Merged
nstarman merged 1 commit intoastropy:mainfrom
WilliamJamieson:bugfix/ignore_memory_policiy_warning
Oct 29, 2021
Merged

Ignore memory policy warning#12331
nstarman merged 1 commit intoastropy:mainfrom
WilliamJamieson:bugfix/ignore_memory_policiy_warning

Conversation

@WilliamJamieson
Copy link
Copy Markdown
Contributor

@WilliamJamieson WilliamJamieson commented Oct 29, 2021

Description

Possibly fixes #12324.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the Extra CI label.
  • Is a change log needed? If yes, did the change log check pass? If no, add the no-changelog-entry-needed label. If this is a manual backport, use the skip-changelog-checks label unless special changelog handling is necessary.
  • Is a milestone set? Milestone must be set but astropy-bot check might be missing; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate backport-X.Y.x label(s) before merge.

@nstarman
Copy link
Copy Markdown
Member

nstarman commented Oct 29, 2021

This does temporarily fix the issue. We need a followup Issue to find where in astropy this can be fixed.
But I think for the sake of other PRs, this can be merged now.
Thanks @WilliamJamieson

@nstarman nstarman merged commit 31e57d0 into astropy:main Oct 29, 2021
@WilliamJamieson WilliamJamieson deleted the bugfix/ignore_memory_policiy_warning branch October 29, 2021 21:54
@pllim pllim added this to the v5.0 milestone Oct 30, 2021
@pllim
Copy link
Copy Markdown
Member

pllim commented Oct 30, 2021

I milestoned this to 5.0 for now. In the future, please ensure milestone is set before you merge, as the milestone check bot is still broken. Thanks!

(Appears branching did not happen yet, so no need to backport.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

memory policy warning in fits with numpy 1.22.0.dev

3 participants