Skip to content

fix #12322#12323

Merged
astrofrog merged 1 commit intoastropy:mainfrom
nstarman:tst-try-to-fix-2322
Oct 29, 2021
Merged

fix #12322#12323
astrofrog merged 1 commit intoastropy:mainfrom
nstarman:tst-try-to-fix-2322

Conversation

@nstarman
Copy link
Member

@nstarman nstarman commented Oct 29, 2021 •
edited
Loading

Signed-off-by: Nathaniel Starkman (@nstarman) [email protected]

Fix #12322

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the Extra CI label.
  • Is a change log needed? If yes, did the change log check pass? If no, add the no-changelog-entry-needed label. If this is a manual backport, use the skip-changelog-checks label unless special changelog handling is necessary.
  • Is a milestone set? Milestone must be set but astropy-bot check might be missing; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate backport-X.Y.x label(s) before merge.

@mhvk mhvk changed the title fix #2322 fix #12322 Oct 29, 2021
@nstarman
Copy link
Member Author

nstarman commented Oct 29, 2021

Hmm. Well that didn't work.

@nstarman nstarman force-pushed the tst-try-to-fix-2322 branch from e79dcc6 to 48823a7 Compare October 29, 2021 03:14
@nstarman
fix astropy#2322
fbe35b4 
Signed-off-by: Nathaniel Starkman (@nstarman) <[email protected]>
@nstarman nstarman force-pushed the tst-try-to-fix-2322 branch from 48823a7 to fbe35b4 Compare October 29, 2021 03:20
@nstarman nstarman linked an issue Oct 29, 2021 that may be closed by this pull request
Numpy distutils deprecation failing all PRs #12322
Closed
@nstarman
Copy link
Member Author

nstarman commented Oct 29, 2021

Ok. This fixes #12322, but there's another, unrelated bug that also needs fixing.

@nstarman nstarman requested review from astrofrog, pllim and saimn October 29, 2021 03:46
@nstarman
Copy link
Member Author

nstarman commented Oct 29, 2021

Note to @astropy/testing-infrastructure-maintainers, I can't request review from the team. I think there's a setting to fix that

@nstarman nstarman requested a review from mhvk October 29, 2021 03:47
@nstarman nstarman mentioned this pull request Oct 29, 2021
Closed
@astrofrog
Copy link
Member

astrofrog commented Oct 29, 2021

I'll merge this since this at least fixes part of the problem

@astrofrog astrofrog merged commit ea648a2 into astropy:main Oct 29, 2021
@nstarman nstarman deleted the tst-try-to-fix-2322 branch October 29, 2021 12:32
@mhvk
Copy link
Contributor

mhvk commented Oct 29, 2021

Probably good to have some follow-up issue for us to actually start using regular sysconfig...

@nstarman nstarman added this to the v5.0 milestone Oct 29, 2021
@saimn
Copy link
Contributor

saimn commented Oct 29, 2021

There is nothing we can do here, it's on Numpy's side :

../../.tox/py310-test-devdeps/lib/python3.10/site-packages/astropy/table/operations.py:25: in <module>
    from . import _np_utils
astropy/table/_np_utils.pyx:11: in init astropy.table._np_utils
    ???
../../.tox/py310-test-devdeps/lib/python3.10/site-packages/numpy/lib/recfunctions.py:16: in <module>
    from numpy.testing import suppress_warnings
../../.tox/py310-test-devdeps/lib/python3.10/site-packages/numpy/testing/__init__.py:13: in <module>
    from ._private import extbuild, decorators as dec
../../.tox/py310-test-devdeps/lib/python3.10/site-packages/numpy/testing/_private/extbuild.py:11: in <module>
    from numpy.distutils.ccompiler import new_compiler
../../.tox/py310-test-devdeps/lib/python3.10/site-packages/numpy/distutils/__init__.py:24: in <module>
    from . import ccompiler
../../.tox/py310-test-devdeps/lib/python3.10/site-packages/numpy/distutils/ccompiler.py:17: in <module>
    from distutils.sysconfig import customize_compiler
/opt/hostedtoolcache/Python/3.10.0/x64/lib/python3.10/distutils/sysconfig.py:58: in <module>
    warnings.warn(
E   DeprecationWarning: The distutils.sysconfig module is deprecated, use sysconfig instead

@mhvk
Copy link
Contributor

mhvk commented Oct 29, 2021

Ah, thanks! Then presumably they'll get to it...

@saimn
Copy link
Contributor

saimn commented Oct 29, 2021

Yes, there is a plan to replace numpy.distutils with meson (for Scipy currently, but I guess if it works Numpy would naturally follow the same lead, https://labs.quansight.org/blog/2021/07/moving-scipy-to-meson/). distutils is deprecated with removal planned for Python 3.12 , so there is time.

@pllim
Copy link
Member

pllim commented Oct 30, 2021 •
edited
Loading

there is a plan

@saimn , where is this plan documented? Is it an issue somewhere in this repo, or do you plan to APE it?

@saimn
Copy link
Contributor

saimn commented Nov 2, 2021

A plan for numpy.distutils ? We use it only via numpy.ctypeslib.load_library, in convolution. We could also find another solution, which is related to #8036.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Cadair Cadair Cadair approved these changes

@pllim pllim Awaiting requested review from pllim

@astrofrog astrofrog Awaiting requested review from astrofrog

@saimn saimn Awaiting requested review from saimn

@mhvk mhvk Awaiting requested review from mhvk

Assignees

No one assigned

Labels

no-changelog-entry-needed

Projects

None yet

Milestone

v5.0

Development

Successfully merging this pull request may close these issues.

Numpy distutils deprecation failing all PRs

6 participants

@nstarman @astrofrog @mhvk @saimn @pllim @Cadair