Skip to content

Cosmo to/from table row - #12313

Merged
nstarman merged 1 commit into
astropy:mainfrom
nstarman:cosmo_tofrom_row
Nov 2, 2021
Merged

Cosmo to/from table row#12313
nstarman merged 1 commit into
astropy:mainfrom
nstarman:cosmo_tofrom_row

Conversation

@nstarman

@nstarman nstarman commented Oct 27, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

Description

Register "astropy.table.Row" with Cosmology I/O.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the Extra CI label.
  • Is a change log needed? If yes, did the change log check pass? If no, add the no-changelog-entry-needed label. If this is a manual backport, use the skip-changelog-checks label unless special changelog handling is necessary.
  • Is a milestone set? Milestone must be set but astropy-bot check might be missing; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate backport-X.Y.x label(s) before merge.

@nstarman nstarman added this to the v5.1 milestone Oct 27, 2021
@github-actions

github-actions Bot commented Oct 27, 2021

Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

nstarman
nstarman commented Oct 27, 2021
View reviewed changes
Comment thread docs/cosmology/io.rst Resolved
@nstarman
nstarman force-pushed the cosmo_tofrom_row branch 2 times, most recently from 75ada3b to ac554a7 Compare October 29, 2021 03:19
@nstarman nstarman mentioned this pull request Oct 29, 2021
Merged
9 tasks done
@pep8speaks

pep8speaks commented Oct 29, 2021 •
edited
Loading

Copy link
Copy Markdown

Hello @nstarman 👋! It looks like you've made some changes in your pull request, so I've checked the code again for style.

There are no PEP8 style issues with this pull request - thanks! 🎉

Comment last updated at 2021-11-02 21:26:08 UTC

@nstarman
nstarman force-pushed the cosmo_tofrom_row branch 7 times, most recently from 7cb7302 to ea02c62 Compare November 2, 2021 02:27
@nstarman
nstarman marked this pull request as ready for review November 2, 2021 02:27
@nstarman
nstarman requested review from mhvk and taldcroft November 2, 2021 02:28
mhvk
mhvk approved these changes Nov 2, 2021
View reviewed changes

@mhvk mhvk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from a small copy & paste typo and a very small request for clarification in the docstring, this all looks good, so I'll approve.

Comment thread astropy/cosmology/io/row.py Outdated


def to_row(cosmology, *args, cosmology_in_meta=False):
"""Serialize the cosmology into a `~astropy.table.QTable`.

@mhvk mhvk Nov 2, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy & paste error... should be Row

@nstarman nstarman Nov 2, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment thread astropy/cosmology/io/row.py Outdated
-------
`~astropy.table.Row`
With columns for the cosmology parameters, and metadata and
cosmology class name in the Table's ``meta`` attribute

@mhvk mhvk Nov 2, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whether the class name is in meta depends on cosmology_in_meta, correct?

@nstarman nstarman Nov 2, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Thanks for the catch!

@nstarman nstarman added the zzz 💤 merge-when-ci-passes Do not use: We have auto-merge option now. label Nov 2, 2021
@nstarman

nstarman commented Nov 2, 2021

Copy link
Copy Markdown
Member Author

Failures appear unrelated, so merging.
Thanks @mhvk!

@nstarman
nstarman merged commit 6a61d49 into astropy:main Nov 2, 2021
@nstarman
nstarman deleted the cosmo_tofrom_row branch November 2, 2021 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mhvk mhvk mhvk approved these changes
@taldcroft taldcroft Awaiting requested review from taldcroft

Assignees

No one assigned

Labels

cosmology Docs table zzz 💤 merge-when-ci-passes Do not use: We have auto-merge option now.

Projects

Cosmology, the Expansion
Status: Done

Milestone

v5.1

Development

Successfully merging this pull request may close these issues.

3 participants

@nstarman @pep8speaks @mhvk