Skip to content

Fixed CI test failures in Azure pipline - #12287

Merged
pllim merged 1 commit into
astropy:mainfrom
WilliamJamieson:bugfix/table_test_warning
Oct 25, 2021
Merged

pllim merged 1 commit into
astropy:mainfrom
WilliamJamieson:bugfix/table_test_warning

Conversation

@WilliamJamieson

Copy link
Copy Markdown
Contributor

…ning` in tests.

Description

When creating the fix in PR #12284 in noticed that the Azure pipline log from issue #12283 had other failures due to astropy warnings being tested as errors raised. This PR should fix the two additional tests which experience this problem.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the Extra CI label.
  • Is a change log needed? If yes, did the change log check pass? If no, add the no-changelog-entry-needed label. If this is a manual backport, use the skip-changelog-checks label unless special changelog handling is necessary.
  • Is a milestone set? Milestone must be set but astropy-bot check might be missing; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate backport-X.Y.x label(s) before merge.

@pllim

pllim commented Oct 25, 2021

Copy link
Copy Markdown
Member

Milestoning this to be consistent with #12129 .

I think this is a problem of us turning all warnings into exceptions in setup.cfg but Azure pipelines does not respect that. But regardless, this is still a correct fix because it is still a warning to begin with.

@pllim

pllim commented Oct 25, 2021

Copy link
Copy Markdown
Member

@Cadair , can you also please enable Azure Pipelines for this one? If not, I guess I'll just approve now and we'll find out after merge...

@astrofrog

astrofrog commented Oct 25, 2021 •

Copy link
Copy Markdown
Member

As an aside the tests on azure run as if one was running astropy.test() (not quite but similar) in which case the setup.cfg file might not be available - so it's not really azure as such that behaves differently but just that we test things differently there because we are testing installed wheels.

@pllim

pllim commented Oct 25, 2021

Copy link
Copy Markdown
Member

#yolo

@pllim
pllim merged commit 84a7182 into astropy:main Oct 25, 2021
@WilliamJamieson
WilliamJamieson deleted the bugfix/table_test_warning branch October 25, 2021 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants