Skip to content

Fixes for refactored bounding box - #12284

Merged
pllim merged 4 commits into
astropy:mainfrom
WilliamJamieson:bugfix/bounding_box_refactor
Oct 25, 2021
Merged

pllim merged 4 commits into
astropy:mainfrom
WilliamJamieson:bugfix/bounding_box_refactor

Conversation

@WilliamJamieson

@WilliamJamieson WilliamJamieson commented Oct 25, 2021 •

Copy link
Copy Markdown
Contributor

Description

This PR fixes bugs introduced by PR #11930 which broke two pieces of CI:

  1. linkcheck in a documentation cron job.
  2. Azure Pipelines.

Fixes #12283

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the Extra CI label.
  • Is a change log needed? If yes, did the change log check pass? If no, add the no-changelog-entry-needed label. If this is a manual backport, use the skip-changelog-checks label unless special changelog handling is necessary.
  • Is a milestone set? Milestone must be set but astropy-bot check might be missing; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate backport-X.Y.x label(s) before merge.

@pllim pllim added this to the v5.0 milestone Oct 25, 2021
@pllim pllim added Affects-dev PRs and issues that do not impact an existing Astropy release Bug no-changelog-entry-needed testing labels Oct 25, 2021
@pllim

pllim commented Oct 25, 2021

Copy link
Copy Markdown
Member

@Cadair , can you please fix that change log first? 👀

@pllim

pllim commented Oct 25, 2021

Copy link
Copy Markdown
Member

@WilliamJamieson , please rebase to pick up CI fix. Thanks!

@WilliamJamieson
WilliamJamieson force-pushed the bugfix/bounding_box_refactor branch from 3177f01 to 63423dc Compare October 25, 2021 15:01
@pllim

pllim commented Oct 25, 2021

Copy link
Copy Markdown
Member

@Cadair , Azure Pipelines does not seem to fire off on subsequent commits.

@Cadair

Cadair commented Oct 25, 2021

Copy link
Copy Markdown
Member

@Cadair , Azure Pipelines does not seem to fire off on subsequent commits.

Indeed.

@pllim

pllim commented Oct 25, 2021

Copy link
Copy Markdown
Member

Well... Can you please kick it off one more time, @Cadair ? Thanks!

@pllim pllim added the Extra CI Run cron CI as part of PR label Oct 25, 2021

@pllim pllim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The remaining linkcheck and Azure failures are unrelated. I'll wait a bit more for RTD to finish but I think this is GTG. Thanks!

@pllim

pllim commented Oct 25, 2021

Copy link
Copy Markdown
Member

Not sure why RTD is taking so long... #yolo

@pllim
pllim merged commit 2a8bc67 into astropy:main Oct 25, 2021
@WilliamJamieson
WilliamJamieson deleted the bugfix/bounding_box_refactor branch October 25, 2021 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Affects-dev PRs and issues that do not impact an existing Astropy release Bug Extra CI Run cron CI as part of PR modeling no-changelog-entry-needed testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TST: Refactored bounding box broke linkcheck, Azure Pipelines

3 participants