Repository navigation
Fixes for refactored bounding box - #12284
Merged
pllim merged 4 commits intoOct 25, 2021
Merged
Conversation
pllim
reviewed
Oct 25, 2021
Member
|
@Cadair , can you please fix that change log first? 👀 |
Member
|
@WilliamJamieson , please rebase to pick up CI fix. Thanks! |
WilliamJamieson
force-pushed
the
bugfix/bounding_box_refactor
branch
from
October 25, 2021 15:01
3177f01 to
63423dc
Compare
pllim
reviewed
Oct 25, 2021
Co-authored-by: P. L. Lim <[email protected]>
pllim
reviewed
Oct 25, 2021
Member
|
@Cadair , Azure Pipelines does not seem to fire off on subsequent commits. |
Co-authored-by: P. L. Lim <[email protected]>
Member
Indeed. |
Member
|
Well... Can you please kick it off one more time, @Cadair ? Thanks! |
9 tasks
pllim
approved these changes
Oct 25, 2021
pllim
left a comment
Member
There was a problem hiding this comment.
The remaining linkcheck and Azure failures are unrelated. I'll wait a bit more for RTD to finish but I think this is GTG. Thanks!
Member
|
Not sure why RTD is taking so long... #yolo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes bugs introduced by PR #11930 which broke two pieces of CI:
Fixes #12283
Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
Extra CIlabel.no-changelog-entry-neededlabel. If this is a manual backport, use theskip-changelog-checkslabel unless special changelog handling is necessary.astropy-botcheck might be missing; do not let the green checkmark fool you.backport-X.Y.xlabel(s) before merge.