Repository navigation
cosmo: improve mapping io and tests - #12209
Merged
Merged
Conversation
|
Hello @nstarman 👋! It looks like you've made some changes in your pull request, so I've checked the code again for style. There are no PEP8 style issues with this pull request - thanks! 🎉 Comment last updated at 2021-10-22 19:24:50 UTC |
nstarman
force-pushed
the
cosmo_improve_mapping
branch
from
September 28, 2021 18:53
b6fb539 to
714c8a1
Compare
nstarman
force-pushed
the
cosmo_improve_mapping
branch
3 times, most recently
from
September 29, 2021 03:14
37b34fb to
69a5205
Compare
Signed-off-by: Nathaniel Starkman (@nstarman) <[email protected]>
nstarman
force-pushed
the
cosmo_improve_mapping
branch
from
October 22, 2021 19:24
69a5205 to
031b1b7
Compare
taldcroft
approved these changes
Oct 26, 2021
taldcroft
left a comment
Member
There was a problem hiding this comment.
Seems straightforward, LGTM.
Member
Author
|
Thanks @taldcroft for the quick review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cosmology instance conversion to dict now accepts keyword argument
clstodetermine dict type, e.g.
OrderedDict. This argument is largely driven byto/from_table(#12213) wherein__astropy_table__allows for aclsargument. Implementing that into_tablemeant doing so here as well. And I think it's the better for it.Also the tests are much improved.
I think the partial information test is impossible to generalize, but this new format of test class inheritance means each format can provide a partial-information test that will be used to test the
to/from_Xfunction as well asCosmology.to/from_format()for each Cosmology subclass.Signed-off-by: Nathaniel Starkman (@nstarman) [email protected]
Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
Extra CIlabel.no-changelog-entry-neededlabel. If this is a manual backport, use theskip-changelog-checkslabel unless special changelog handling is necessary.astropy-botcheck might be missing; do not let the green checkmark fool you.backport-X.Y.xlabel(s) before merge.