Repository navigation
Conversation
[skip ci]
these together write the CDS Data Table without the ReadMe header. [skip ci]
this is done via `test_write_data` func in `test_cds.py` [skip ci]
[skip ci]
including `test_write_ByteByByte_units` [skip ci]
Also got the `cdsdict` argument passing working. The user can pass it using `ascii.write(Writer=ascii.Cds, cdsdict={})` or `table.write(format='cds', cdsdict={})`.
[skip ci]
and for ByteByByte description of columns with Null values [skip ci]
[skip ci]
also edited last line of ReadMe template [skip ci]
[skip ci]
Correct expression for `nsplit`. Add `test_write_byte_by_byte_bytes_col_format` and `test_write_byte_by_byte_wrapping` functions. [skip ci]
correctly place `# noqa: W291` at end of every closing triple quotes. This works fine now, so no need for `# flake8: noqa: W291` to not checking codestyle of whole file. reduce output lenght of `test_bbbWrap` func and other corrections. add MRT_TEMPLATE [skip ci]
[skip ci]
[skip ci]
[skip ci]
add a diff second col in `coord_cols` test output copy table before writing to CDS format [skip ci]
add exception for column with partial `SkyCoord` values. add `else` statement for `SkyCoord` columns not in `SphericalRepresenation` convert other `mixin` and partial `SkyCoord` col vals to str and have column label for them as `Unknown` add test `test_write_mixin_and_broken_cols` [skip ci]
add `test_write_extra_SkyCoord_cols` test delete ReadMe template file [skip ci]
put all imports in `test_cds.py` to file start make `SkyCoord` import local use only `if not isinstance(col, Column)` checking values of `col.info.format` and `col.format` in the cases when no `formats` argument is passed. [skip ci]
BBB was not correctly taking the format passed in the `formats` argument. minor change in the format issuing part some extra useless trailing zeros are appended sometimes to the table column float values, which is why `col.meta.size` being calculated is sometimes different from what is obtained from `len(max(col.str_vals))` edit exception in `_split_float_format` [skip ci]
edit coord tests to reflect default format [skip ci]
add `test_write_mrt_metadata_notes_for_mixin_cols` test add `test_write_mrt_metadata_repeated_notes` test add `test_write_mrt_metadata_wrapping` test add `test_write_mrt_metadata_global_notes` test add `test_write_mrt_metadata` test
|
This PR is the work done to add getting MRT metadata from the user for CDS/MRT format table writing. |
|
Brief summary and some comments:
|
|
Have done a clever trick of using the column name in The above would note :) work when the reference is made before the notes for the previous column have been defined. Else, the notes will be repeated in the ReadMe even if the In other words, Reference to the same column note can be assigned by passing the name of the first column whose note has to be repeated, to the |
|
Notes and notes referencing doesn't work for mix-in columns because they are not |
|
A further point about note-taking in MRT/CDS,
|
|
Hi humans 👋 - this pull request hasn't had any new commits for approximately 4 months. I plan to close this in 30 days if the pull request doesn't have any new commits by then. In lieu of a stalled pull request, please consider closing this and open an issue instead if a reminder is needed to revisit in the future. Maintainers may also choose to add keep-open label to keep this PR open but it is discouraged unless absolutely necessary. If this PR still needs to be reviewed, as an author, you can rebase it to reset the clock. If you believe I commented on this pull request incorrectly, please report this here. |
|
@Suyog7130 Do you think you'll have time to continue this (and the other PRs)? If now, should @aaryapatil and I see if we can take it over? We'd love you to be a regular contributor to astropy, but it would also be bad to see this PR just closed and the work that already went into it forgotten. We've gone so far already with the first PRs you did, I'd love to see these finished, too. |
|
I'm going to close this pull request as per my previous message. If you think what is being added/fixed here is still important, please remember to open an issue to keep track of it. Thanks! If this is the first time I am commenting on this issue, or if you believe I closed this issue incorrectly, please report this here. |
|
@Suyog7130 Shoudl we re-open this? |
|
Yes, that would be great. I will push new commits to the PR soon. |
|
Hello @Suyog7130 👋! It looks like you've made some changes in your pull request, so I've checked the code again for style.
|
pllim
removed
Close?
|
Hi humans 👋 - this pull request hasn't had any new commits for approximately 6 months. I plan to close this in 30 days if the pull request doesn't have any new commits by then. In lieu of a stalled pull request, please consider closing this and open an issue instead if a reminder is needed to revisit in the future. Maintainers may also choose to add keep-open label to keep this PR open but it is discouraged unless absolutely necessary. If this PR still needs to be reviewed, as an author, you can rebase it to reset the clock. If you believe I commented on this pull request incorrectly, please report this here. |
|
I'm going to close this pull request as per my previous message. If you think what is being added/fixed here is still important, please remember to open an issue to keep track of it. Thanks! If this is the first time I am commenting on this issue, or if you believe I closed this issue incorrectly, please report this here. |
Description
This Pull Request is part of the 2021 Google Summer of Code work I am doing together with mentors @aaryapatil and @hamogu.
It is a continuation of the modifications in #11897 and #12027 which primarily aims to address issue #11257.
Note that the count appended at the end of the PR title, [GSoC21a], [GSoC21b] and so on, denote the sequence in which rebasing has been (will be) done to the commits. It is preferred if the merging also takes place in this order. Also, because the previous PRs are not merged yet, the later ones contain numerous unrelated commits at the time of opening the PR.
Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
Extra CIlabel.no-changelog-entry-neededlabel.astropy-botcheck might be missing; do not let the green checkmark fool you.backport-X.Y.xlabel(s) before merge.