Skip to content

improve Cosmology init signatures - #11906

Merged
mhvk merged 1 commit into
astropy:mainfrom
nstarman:cosmo_improve_inits
Jun 30, 2021
Merged

mhvk merged 1 commit into
astropy:mainfrom
nstarman:cosmo_improve_inits

Conversation

@nstarman

@nstarman nstarman commented Jun 30, 2021 •

Copy link
Copy Markdown
Member

Signed-off-by: Nathaniel Starkman (@nstarman) [email protected]

Blocking #11559
Suggested labels: no-changelog-needed, merge-when-CI-passes
Request Review: @mhvk (from discussion in #11559 )

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will
review this pull request of some common things to look for. This list
is not exhaustive.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the Extra CI label.
  • Is a change log needed? If yes, did the change log check pass? If no, add the no-changelog-entry-needed label.
  • Is a milestone set? Milestone must be set but astropy-bot check might be missing; do not let the green checkmark fool you.
  • If the milestone set requires a backport to release branch(es), apply the appropriate backport-X.Y.x label(s) before merge.

Signed-off-by: Nathaniel Starkman (@nstarman) <[email protected]>

@mhvk mhvk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mhvk mhvk added this to the v5.0 milestone Jun 30, 2021
@mhvk mhvk added the zzz 💤 merge-when-ci-passes Do not use: We have auto-merge option now. label Jun 30, 2021
@nstarman

nstarman commented Jun 30, 2021 •

Copy link
Copy Markdown
Member Author

Passed. The changelog check is not updating for some reason.

@mhvk
mhvk merged commit 58eb7bf into astropy:main Jun 30, 2021
@nstarman

Copy link
Copy Markdown
Member Author

Thanks!

@nstarman
nstarman deleted the cosmo_improve_inits branch June 30, 2021 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants