Skip to content

Mark test as requiring jplephem. - #11858

Merged
mhvk merged 1 commit into
astropy:mainfrom
mhvk:coordinates-tests-requires-jplephem
Jun 21, 2021
Merged

mhvk merged 1 commit into
astropy:mainfrom
mhvk:coordinates-tests-requires-jplephem

Conversation

@mhvk

@mhvk mhvk commented Jun 18, 2021

Copy link
Copy Markdown
Contributor

An oversight in some previous PR. Should be backported to 4.3. Partially addresses #11857.

@pllim pllim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll leave it open in case @eteq wants to keep track of things for release.

@mhvk

mhvk commented Jun 21, 2021

Copy link
Copy Markdown
Contributor Author

I'm going to merge this as it is makes the tests on master fail as well (while listed as allowed failure, people do still have to check, so it is annoying). @eteq - let me know if you want help to backport (though it should be a trivial one).

@mhvk
mhvk merged commit 13904c4 into astropy:main Jun 21, 2021
@mhvk
mhvk deleted the coordinates-tests-requires-jplephem branch June 21, 2021 21:06
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Jun 22, 2021
mhvk added a commit that referenced this pull request Jun 23, 2021
…858-on-v4.3.x

Backport PR #11858 on branch v4.3.x (Mark test as requiring jplephem.)
@eteq eteq modified the milestones: v4.3.1, v4.3 Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants