Repository navigation
Close files alternative - #11810
Closed
mhvk wants to merge 8 commits into
Closed
Close files alternative#11810mhvk wants to merge 8 commits into
mhvk wants to merge 8 commits into
Conversation
Contributor
|
👋 Thank you for your draft pull request! Do you know that you can use |
Contributor
Author
|
closing in favour of #11809 - the approach here can leave a filehandle in a state where just doing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #11809, just for discussion. cc @larrybradley, @pllim, @embray
This one does the detach more explicitly in the
finallyclause. It still has one failing tests (which also fails in #11809)