Repository navigation
Print nice error message if sphinx_changelog is not installed - #11797
Merged
Merged
Conversation
pllim
reviewed
May 28, 2021
Member
|
Maybe a more general solution might be nice? 👼 |
Member
|
Perhaps... but I'll leave it to Larry whether generalization is out of scope or not. |
Contributor
|
Should sphinx-changelog be added as a dependency for sphinx-astropy ? |
larrybradley
force-pushed
the
sphinx_changelog
branch
from
June 2, 2021 17:47
9338000 to
c4f89ae
Compare
Member
Author
pllim
reviewed
Jun 2, 2021
| except ImportError: | ||
| print('ERROR: the documentation requires the sphinx-astropy package to be installed') | ||
| # -- Check for missing dependencies ------------------------------------------- | ||
| doc_requires = get_distribution("astropy").requires(extras=("docs",)) |
larrybradley
force-pushed
the
sphinx_changelog
branch
from
June 3, 2021 03:38
c4f89ae to
e192317
Compare
Member
|
Does this really need backport? I don't think so... I am changing the milestone. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building docs locally requires the
sphinx_changelogpackage.