Repository navigation
Remove error mapping in cosmology cloning - #11785
Merged
Merged
Conversation
nstarman
force-pushed
the
cosmo_deprecate_error_map
branch
from
May 24, 2021 18:23
0da7cac to
562ee68
Compare
Member
|
I thought we tend to avoid starting a deprecation in a LTS release, no? |
Member
Author
|
Sorry. I misspoke. This was already deprecated in v4.3 and is now removed. |
nstarman
changed the title
pllim
reviewed
May 24, 2021
nstarman
force-pushed
the
cosmo_deprecate_error_map
branch
from
May 24, 2021 18:30
562ee68 to
8530333
Compare
pllim
reviewed
May 24, 2021
nstarman
force-pushed
the
cosmo_deprecate_error_map
branch
2 times, most recently
from
May 24, 2021 19:05
d48f18e to
4b3770a
Compare
Contributor
|
But of course now it needs a rebase... |
Co-authored-by: P. L. Lim <[email protected]> Signed-off-by: Nathaniel Starkman (@nstarman) <[email protected]>
nstarman
force-pushed
the
cosmo_deprecate_error_map
branch
from
May 25, 2021 03:21
4b3770a to
c1ed121
Compare
Contributor
|
OK, all approved, rebased and green, so merging! Thanks, @nstarman |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nathaniel Starkman (@nstarman) [email protected]
A deprecation marked for v5.0.
Request review: @mhvk