Repository navigation
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to Astropy 👋 and congratulations on your first pull request! 🎉
A project member will respond to you as soon as possible; in the meantime, please have a look over the Checklist for Contributed Code and make sure you've addressed as many of the questions there as possible.
If you feel that this pull request has not been responded to in a timely manner, please leave a comment mentioning our software support engineer @embray, or send a message directly to the development mailing list. If the issue is urgent or sensitive in nature (e.g., a security vulnerability) please send an e-mail directly to the private e-mail [email protected].
|
Thanks! I didn't "approve" the CI because it doesn't affect Azure Pipelines. Not sure how to kick off Azure here. I am also not sure about a change log, though having one doesn't hurt? Let's wait and see what others say. |
|
I don't know much about azure so I will leave it to @Cadair (who must know how to start the azure builds ;)). |
|
We can kick this off when the azure templates PR has been fixed, at the moment the CI over there isn't passing. |
This comment has been minimized.
This comment has been minimized.
|
Does explicitly removing the close label stop the bot closing it @pllim ? The upstream component of this just got fixed, so hopefully we can ship aarch64 wheels with 5.0. |
[ci skip]
|
I manually fired off a build for this PR, let's see how it goes, although we know the build is broken anyway #12170 |
|
@odidev can you take a look at this, it doesn't seem to have gone well 🤣 |
|
It seems that 3.10 has (finally) gone live on Azure and cibuildwheel wont build 3.7 wheels while using Python 3.10... |
|
Turns out that isn't the issue. I assume this is a wider issue than this PR. The actual aarch64 part seems to work fine. |
|
Wait a min... We dropped Python 3.7. So this PR does not make sense. |
Now is the time I test this doc I wrote... 😸 https://docs.astropy.org/en/latest/development/workflow/maintainer_workflow.html#pull-requests |
|
This isn't the PR to turn into a cleanup of our Azure pipelines config. We should merge this as-is and I will fix it later because of both #12170 and removing 3.7 and adding 3.10? |
Co-authored-by: P. L. Lim <[email protected]>
|
@odidev Thanks a lot for this PR and the change upstream. I need to do some refactoring of the pipelines script, so I am going to take your commits and make a new PR with all the needed changes in for 5.0. I will therefore close this. |
|
xref #12292 |
|
I can see that the steps to build Linux AArch64 wheels are commented because of slow build due to emulation. How about using Circle CI to build Linux AArch64 wheels? I can see, Circle CI is already added to this project, we just need to add build steps. @Cadair, what are your thoughts on this? |
@pllim, what are your thoughts on this? |
|
@odidev , that wheels infrastructure is currently maintained by @Cadair and @astrofrog , so I will defer to their good judgement. They might be slow to respond due to personal reasons, so we ask for your continue patience. Thanks! Also, you can try to re-open this discussion over at http://joinslack.astropy.org/ in its |
|
My concern with using circleci would be the added complexity, but it's certainly possible and would still presumably use cibuildwheel. |
Added linux aarch64 wheel build support
Fixes #11731. @saimn Could you please review this PR?
azure-pipeline-template PR: #67