Skip to content

Updates for testing towncrier 21.3 - #11726

Merged
pllim merged 3 commits into
astropy:mainfrom
Cadair:sphinx-changelog11
May 12, 2021
Merged

Updates for testing towncrier 21.3#11726
pllim merged 3 commits into
astropy:mainfrom
Cadair:sphinx-changelog11

Conversation

@Cadair

@Cadair Cadair commented May 11, 2021 •
edited by pllim
Loading

Copy link
Copy Markdown
Member

This tests the new sphinx-changelog 1.1.0rc1 which uses towncrier 21.3

Close #11728

Cadair
Cadair commented May 11, 2021
View reviewed changes
Comment thread CHANGES.rst
- Removed dependency on scikit-image. [#10214]


4.0.6 (unreleased)

@Cadair Cadair May 11, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't think we should have unreleased sections in the changelog now we are using towncrier, but can revert if I am missing something.

@github-actions

github-actions Bot commented May 11, 2021

Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@Cadair

Cadair commented May 11, 2021

Copy link
Copy Markdown
Member Author

Seems to work: https://astropy--11726.org.readthedocs.build/en/11726/changelog.html

@Cadair

Cadair commented May 11, 2021

Copy link
Copy Markdown
Member Author

I have just pushed the final 1.1.0 release.

@Cadair Cadair mentioned this pull request May 11, 2021
Closed
@pllim pllim added this to the v4.0.6 milestone May 11, 2021
@pllim pllim added the Docs label May 11, 2021
@pllim

pllim commented May 11, 2021

Copy link
Copy Markdown
Member

@Cadair , if this is ready, please get it out of draft state and ping people to review. Thanks!

@Cadair
Cadair marked this pull request as ready for review May 12, 2021 09:45
@Cadair
Cadair requested review from bsipocz, pllim and saimn May 12, 2021 09:45
pllim
pllim reviewed May 12, 2021
View reviewed changes
Comment thread setup.cfg Resolved
@Cadair
Update setup.cfg
faced8e 
[ci skip]
pllim
pllim approved these changes May 12, 2021
View reviewed changes

@pllim pllim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks fine at https://astropy--11726.org.readthedocs.build/en/11726/changelog.html . But let's see what others say.

@pllim

pllim commented May 12, 2021

Copy link
Copy Markdown
Member

Also I am not sure about the milestone...

@Cadair

Cadair commented May 12, 2021

Copy link
Copy Markdown
Member Author

We should backport this to all supported branches imo

saimn
saimn approved these changes May 12, 2021
View reviewed changes

@saimn saimn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me 👍

@pllim
pllim merged commit 715d7a6 into astropy:main May 12, 2021
@Cadair
Cadair deleted the sphinx-changelog11 branch May 13, 2021 12:37
@saimn saimn mentioned this pull request May 28, 2021
Merged
@pllim pllim mentioned this pull request May 28, 2021
Merged
eteq pushed a commit that referenced this pull request Jun 11, 2021
@pllim @eteq
Merge pull request #11726 from Cadair/sphinx-changelog11
3977cea 
Updates for testing towncrier 21.3
@eteq

eteq commented Jun 11, 2021

Copy link
Copy Markdown
Member

backported to v4.3.x in 3977cea

astrofrog pushed a commit that referenced this pull request Aug 16, 2021
@pllim @astrofrog
Merge pull request #11726 from Cadair/sphinx-changelog11
2c0f690 
Updates for testing towncrier 21.3
astrofrog added a commit to astrofrog/astropy that referenced this pull request Aug 18, 2021
@astrofrog
Fix incomplete backport of astropy#11726
82f2f13
@astrofrog

astrofrog commented Aug 18, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

For the record the backport of this to v4.0.x was incomplete (2c0f690) - I've added the missing changes to #12075

astrofrog added a commit to astrofrog/astropy that referenced this pull request Aug 18, 2021
@astrofrog
Fix incomplete backport of astropy#11726
db33e9e
astrofrog added a commit that referenced this pull request Aug 18, 2021
@astrofrog
Backport changes to towncrier template from #11726
97cfd8d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saimn saimn saimn approved these changes
@pllim pllim pllim approved these changes
@bsipocz bsipocz Awaiting requested review from bsipocz

Assignees

No one assigned

Labels

Docs installation no-changelog-entry-needed

Projects

None yet

Milestone

v4.0.6

Development

Successfully merging this pull request may close these issues.

5 participants

@Cadair @pllim @eteq @astrofrog @saimn