Repository navigation
Fix parsing of blank values in ECSV subtype data - #11720
Merged
taldcroft merged 4 commits intoMay 11, 2021
Merged
Conversation
Contributor
|
Thanks @taldcroft , I think this change in the specification and implementation will make the ECSV subtypes a more useful thing to have. Apologies my earlier dithering on this contributed to lateness of the update; I agree it would be nice if possible for it to appear with the initial ECSV implementation rather than a later bugfix. |
mhvk
approved these changes
May 10, 2021
mhvk
left a comment
mhvk
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Happy to approve but perhaps good to rebase to ensure that all the tests pass (current failure is resolved in main, but it blocks other tests from running)
taldcroft
force-pushed
the
ascii-ecsv-blank-value-subtypes
branch
from
May 11, 2021 12:32
7aebddb to
66cbe85
Compare
taldcroft
force-pushed
the
ascii-ecsv-blank-value-subtypes
branch
from
May 11, 2021 13:04
66cbe85 to
1ba9c59
Compare
eteq
pushed a commit
that referenced
this pull request
Jun 11, 2021
Fix parsing of blank values in ECSV subtype data
Member
|
backported to v4.3.x in 54f58bc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request is another follow-on to #11569 and fixes the implementation to correctly parse fields that have a blank (empty string) value in subtype columns (object, fixed array, variable array). The APE-6 update will now specify that blank values are allowed in subtype columns as an indicator of missing data.
This is obviously late. If need be this fix could be pushed to the first bug-fix release for 4.3, but getting it in for the 4.3 release itself is preferred.
@mhvk @mbtaylor