Repository navigation
Try to avoid pyinstaller failure of unavailable available package - #11712
Merged
Merged
Conversation
mhvk
added
testing
coordinates
no-changelog-entry-needed
Extra CI
mhvk
force-pushed
the
coordinates-pyinstaller-fix
branch
2 times, most recently
from
May 6, 2021 17:58
982b247 to
03e1014
Compare
mhvk
force-pushed
the
coordinates-pyinstaller-fix
branch
from
May 6, 2021 17:58
03e1014 to
034d959
Compare
pllim
approved these changes
May 6, 2021
pllim
left a comment
pllim
left a comment
Member
There was a problem hiding this comment.
LGTM. Let's see what pyinstaller job thinks. Thanks for the quick fix!
pllim
added
the
zzz 💤 merge-when-ci-passes
Contributor
Author
|
pyinstaller job passed! |
Member
|
Might as well wait for the rest... Linkcheck failure is unrelated and appears transient. |
pllim
added a commit
to pllim/astropy
that referenced
this pull request
Jun 22, 2021
Try to avoid pyinstaller failure of unavailable available package
9 tasks
pllim
added a commit
to pllim/astropy
that referenced
this pull request
Jun 22, 2021
Try to avoid pyinstaller failure of unavailable available package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should address the pyinstaller failure noted in #11700 (comment)... 🤞
I went for the try/except route since I wasn't sure the in-test check would work any better than that inside
pytest.mark.skipif, and this seemed slightly cleaner.