Repository navigation
Fix problem with multidim Table repr in Jupyter introduced in #11569 - #11703
Merged
Merged
Conversation
taldcroft
added
table
io.ascii
Bug
Affects-dev
Member
Author
|
@eteq - this seems like a critical bug fix and should go into 4.3. |
keflavich
approved these changes
May 5, 2021
keflavich
left a comment
keflavich
left a comment
Contributor
There was a problem hiding this comment.
lgtm, but I don't know much about notebooks under the hood either
saimn
approved these changes
May 6, 2021
saimn
left a comment
saimn
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the quick fix. It seems better anyway that _repr_latex_ doesn't crash with multidimensional columns.
Member
Author
I agree since latex is not really a format that one would use to round-trip data. Based on that we should leave this in despite backing out the root problem in #11711. |
Member
|
Does this need a revert too? |
Member
Author
|
I think not. |
eteq
pushed a commit
that referenced
this pull request
Jun 11, 2021
Fix problem with multidim Table repr in Jupyter introduced in #11569
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request is to fix a problem with multidim Table repr in Jupyter introduced in #11569.
This is a one-line change that reverts strict checking of the latex io.ascii writer regarding support for outputting multidimensional columns. This is therefore going back to the 4.2 behavior where writing a multidim column to latex uses the
val1 .. valNrepresentation. This is not strictly correct since it won't round-trip, but better to have this legacy behavior than have Jupyter fail to display such tables.Functional testing
Fixes #11695
cc: @keflavich @saimn