Skip to content

Change ECSV subtype=object to subtype=json - #11662

Merged
taldcroft merged 1 commit into
astropy:mainfrom
taldcroft:ascii-ecsv-object-to-json
Apr 29, 2021
Merged

taldcroft merged 1 commit into
astropy:mainfrom
taldcroft:ascii-ecsv-object-to-json

Conversation

@taldcroft

Copy link
Copy Markdown
Member

Description

Over in astropy/astropy-APEs#68 @mbtaylor requested this change, which seems like a good idea.

@saimn or @pllim - this is an example of a follow-on PR that is really part of #11569. I seem to recall that I am supposed to use the same feature message and this will then put both PR numbers in the change log. Did I get that right?

@taldcroft taldcroft added this to the v4.3 milestone Apr 29, 2021
@github-actions github-actions Bot added the table label Apr 29, 2021
@pllim pllim added the Affects-dev PRs and issues that do not impact an existing Astropy release label Apr 29, 2021
@pllim

pllim commented Apr 29, 2021

Copy link
Copy Markdown
Member

Did I get that right?

I think so, but @saimn should confirm.

@pllim pllim left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks uncontroversial to me, but someone else from the other PR should also look. I tagged the person who approved the other PR for review.

@pllim
pllim requested a review from mhvk April 29, 2021 14:25
@saimn

saimn commented Apr 29, 2021

Copy link
Copy Markdown
Contributor

@mhvk mhvk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see that it is indeed a simple change to implement the suggestion of @mbtaylor!

@taldcroft
taldcroft merged commit 3d1efd3 into astropy:main Apr 29, 2021
@taldcroft
taldcroft deleted the ascii-ecsv-object-to-json branch April 29, 2021 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Affects-dev PRs and issues that do not impact an existing Astropy release io.ascii table

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants