Skip to content

Correct test for changes to native byte order - #11543

Closed
mhvk wants to merge 1 commit into
astropy:mainfrom
mhvk:table-test-pickle-byteorder
Closed

mhvk wants to merge 1 commit into
astropy:mainfrom
mhvk:table-test-pickle-byteorder

Conversation

@mhvk

@mhvk mhvk commented Apr 13, 2021 •

Copy link
Copy Markdown
Contributor

fixes #11339

I think the test was simply written incorrectly.

EDIT: only merge if the s390x test passes!!

@dhomeier

Copy link
Copy Markdown
Contributor

I've tested this locally with defining a non-native 'ndarray', and it fails apparently because the complex dtype([('f0', '>i4'), ('f1', 'S1')])'s byteorder is preserved under pickling and init_from_class. So the way out may rather be to specifically check for those (dtype.name = 'void*'), but I stand corrected if s390x passes.

@saimn

saimn commented Apr 13, 2021

Copy link
Copy Markdown
Contributor

Needs a rebase for the importlib_metadata issue (for Python 3.7)

@mhvk

mhvk commented Apr 13, 2021

Copy link
Copy Markdown
Contributor Author

closing in favour of the better solution at #11545

@mhvk mhvk closed this Apr 13, 2021
@mhvk
mhvk deleted the table-test-pickle-byteorder branch April 13, 2021 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TST: test_info_preserved_pickle_copy_init failed on s390x with TypeError: data type 'void40' not understood

3 participants