Repository navigation
cosmotics - #11540
Merged
Merged
cosmotics#11540
Conversation
mhvk
reviewed
Apr 13, 2021
mhvk
left a comment
mhvk
left a comment
Contributor
There was a problem hiding this comment.
Mostly looks good, except really not sure about the str or None idea, since None seems there just as a placeholder, not something you'd hope people actually pass in.
hamogu
approved these changes
Apr 13, 2021
Member
|
Re: |
Closed
Signed-off-by: Nathaniel Starkman (@nstarman) <[email protected]>
Member
Author
Contributor
|
OK, sorry, this was all resolved and approved. So, merging now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The smallest of cosmetics. No changelog needed.
Blocking: #11542