Repository navigation
Fix test failing after backport of #11285 - #11438
Merged
Merged
Conversation
With the backport of astropy#11285 on v4.2, a new warning is rasied and turned into an error. This doesn't happen on v4.0 because the way to catch warning changed (using pytest) and does not happen on master/4.3 because some new code was added to detect if the file is a valid FITS file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the backport of #11285 on v4.2, a new warning is rasied and turned
into an error. This doesn't happen on v4.0 because the way to catch
warning changed (using pytest) and does not happen on master/4.3 because
some new code was added to detect if the file is a valid FITS file.
cc @eteq @pllim
ref #11415 and #11430