Repository navigation
xfail test_against_pyephem on v4.2.x - #11430
Merged
Merged
Conversation
pllim
reviewed
Mar 26, 2021
| assert distance_noatm < 0.4 * u.arcsec | ||
|
|
||
|
|
||
| @pytest.mark.skipif(reason="See https://github.com/astropy/astropy/issues/11305") |
Member
Member
pllim
approved these changes
Mar 26, 2021
pllim
left a comment
pllim
left a comment
Member
There was a problem hiding this comment.
I am just gonna approve to remove the merge block for the sake of getting the release done. If others disagree, they can "request changes."
Member
|
No objection, so merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a PR specifically to the v4.2.x branch to allow a release without needing to fix the test described more in #11305 . The conclusion in that issue is that this is a testing problem in that newer versions of pyerfa have a better algorithm, and the test is a red herring in that it's failing only because the algorithm was improved.
So this PR is straight into 4.2.x to xfail that test for now. We'll probably want to revert this once #11305 is fixed, but since it's purely the test it's not a big deal either way I think.