Repository navigation
Manual backport of #11250 (Ensure that the CDS unit parser can deal with '[-]') - #11418
Merged
Merged
Conversation
Ensure that the CDS unit parser can deal with '[-]'
pllim
commented
Mar 24, 2021
| - Ensure ``keepdims`` works for taking ``mean``, ``std``, and ``var`` of | ||
| ``Quantity``. [#11198] | ||
|
|
||
| - For CDS units and tables, recognize ``-`` as indicating dimensionless and |
Member
Author
There was a problem hiding this comment.
Do I have to move the change log?
Contributor
|
The backport looks good (except this time I think the changelog should be moved as it really won't be in 4.0 any more - in fact, shouldn't it be moved in master if we do not end up backporting to 4.0? let me comment there too) I don't understand the failures, though... They seem totally unrelated. |
Member
Author
|
The failures are from #11305 , I think? |
Contributor
|
Darn, reminds me that we need a pyerfa 1.7.3... |
Member
|
Yeah, I agree the failures are unrelated. To finish backporting I'm going to merge this, but I think we need to either xfail or make sure 1.7.3 is out first (and exclude 1.7.2) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that the CDS unit parser can deal with '[-]'
Description
This pull request is to manually backport #11250