Repository navigation
Manual backport of #11145 (Use proper precision when format not specified) - #11416
Merged
Merged
Conversation
…format Use proper precision when format not specified
pllim
commented
Mar 24, 2021
| - Ensure ``keepdims`` works for taking ``mean``, ``std``, and ``var`` of | ||
| ``Quantity``. [#11198] | ||
|
|
||
| - For ``Quantity.to_string()``, ensure that the precision argument is also |
Member
Author
There was a problem hiding this comment.
Do I have to move the change log as part of the manual backport?
Contributor
There was a problem hiding this comment.
I would think merging is at the time of the release, but am not sure...
mhvk
approved these changes
Mar 24, 2021
mhvk
left a comment
mhvk
left a comment
Contributor
There was a problem hiding this comment.
Looks good except I don't know the answer to the question about the changelog. I think, though, it should just be backported as is.
Member
|
I think it's right to leave the changelog as it is here. I'm not going to worry too much about it since towncrier will make this all mott anyway in future versions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use proper precision when format not specified
Description
This pull request is to manually backport #11145 for 4.2.1.