Repository navigation
Manual backport for #11108 (Don't re-verify invalid FITS cards after their values have been replaced) - #11415
Merged
Merged
Conversation
Member
Author
|
I am not 100% sure about this, please review carefully. |
pllim
commented
Mar 24, 2021
| astropy.io.fits | ||
| ^^^^^^^^^^^^^^^ | ||
|
|
||
| - Fix bug where manual fixes to invalid header cards were not preserved when |
Member
Author
There was a problem hiding this comment.
This is still listed under 4.0.5. Do I have to move it as part of the manual backport?
Member
There was a problem hiding this comment.
No, it should stay here just as you've done.
pllim
marked this pull request as ready for review
March 24, 2021 20:43
[astropy#5408] Don't re-verify invalid FITS cards after their values have been replaced
Member
Author
|
I think the tests will fail with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request is to manually backport #11108 to v4.2.x