You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
TST: Skip CI natively, DOC: Update license year - #11316
Also updated license year, because I needed a second commit to make sure it doesn't skip when second commit doesn't have the directive. Might as well put in a real change, right? Seems to work!
For the first two points in Cons, let's see how actions/runner#976 goes. For the last two points, we might just have to live with it or have a way to scrub out trigger directive from the merge commit message before merge (is that even possible without much pain?).
Update: Merge commit message only has the PR title, so CI is running. There is still an edge case of what if someone put the directly in PR title but that is so rare (and discouraged) that it isn't really an issue. Seeing this, cron probably will be okay too, since we rarely push directly into master with any skip directive, if at all.
jdavies-st
pushed a commit
to spacetelescope/jwst
that referenced
this pull request
Feb 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pllim
changed the title
Description
Supposedly, this should Just Work ™️ now...
https://github.blog/changelog/2021-02-08-github-actions-skip-pull-request-and-push-workflows-with-skip-ci/
Direct follow-up of #11168 and #11274 . Also see #11038
Also updated license year, because I needed a second commit to make sure it doesn't skip when second commit doesn't have the directive. Might as well put in a real change, right? Seems to work!
Pros
Cons
.github/workflows, including labeler and triage actions, which is undesirable.Might also skip a merge commit inSee TST: Skip CI natively, DOC: Update license year #11316 (comment)masterwhen PR is merged if the merge commit message collates all PR commit messages into one, and one or more of the PR commits had the trigger in it.Might also skip a cron job run if the last commit inSee TST: Skip CI natively, DOC: Update license year #11316 (comment)masteris a message with the trigger.For the first two points in Cons, let's see how actions/runner#976 goes. For the last two points, we might just have to live with it or have a way to scrub out trigger directive from the merge commit message before merge (is that even possible without much pain?).