Repository navigation
FITS: Allow multiple leading spaces in value field for RVKC input format - #11301
Merged
Merged
Conversation
Contributor
|
Seems reasonable. Please add the changelog entry. |
astrofrog
pushed a commit
that referenced
this pull request
Mar 16, 2021
FITS: Allow multiple leading spaces in value field for RVKC input format
eteq
pushed a commit
that referenced
this pull request
Mar 25, 2021
FITS: Allow multiple leading spaces in value field for RVKC input format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a bug fix or enhancement for a minor issue that arose in relation to #11260:
The
io.fits.Cardfilters for identifying record-valued key cards were rejecting multiple spaces in the value field after the:, therefore not recognising header cards written by WCSLIB likeas RVKC and thus not making them accessible as e.g.
header['DQ1.AUX.1.COEFF...'].Since the syntax does not seem to forbid extra space, and anyway WCSLIB is using it gratuitously in writing its headers, I have extended the
reaccordingly and modified a few tests for this format.