Repository navigation
WIP: Add GPS time scale - #11269
WIP: Add GPS time scale#11269taldcroft wants to merge 1 commit into
Conversation
|
Should we move the milestone given the upcoming feature freeze and the WIP state of this PR? |
|
Hi humans 👋 - this pull request hasn't had any new commits for approximately 7 months. I plan to close this in 30 days if the pull request doesn't have any new commits by then. In lieu of a stalled pull request, please consider closing this and open an issue instead if a reminder is needed to revisit in the future. Maintainers may also choose to add keep-open label to keep this PR open but it is discouraged unless absolutely necessary. If this PR still needs to be reviewed, as an author, you can rebase it to reset the clock. If you believe I commented on this pull request incorrectly, please report this here. |
|
Hi humans 👋 - this pull request hasn't had any new commits for approximately 7 months. I plan to close this in 30 days if the pull request doesn't have any new commits by then. In lieu of a stalled pull request, please consider closing this and open an issue instead if a reminder is needed to revisit in the future. Maintainers may also choose to add keep-open label to keep this PR open but it is discouraged unless absolutely necessary. If this PR still needs to be reviewed, as an author, you can rebase it to reset the clock. If you believe I commented on this pull request incorrectly, please report this here. |
|
Ops, sorry for the double bot post. Hopefully I fixed the bug upstream. |
|
I'm going to close this pull request as per my previous message. If you think what is being added/fixed here is still important, please remember to open an issue to keep track of it. Thanks! If this is the first time I am commenting on this issue, or if you believe I closed this issue incorrectly, please report this here. |
Description
This pull request is to add a new GPS time scale
gps_scalewhich is TAI - 19 sec. This is basically a go-back and change of course from #1879.This is the first instance of adding a new custom time scale that is not handled by ERFA. At first glance it isn't too hard, though of course if we keep doing this then the transform graph will start getting longer and longer. But for this first one just enumerating the transforms was easy enough.
I do wish we could have a do-over on #1164 and call the time format
gps_sec(alacxcsec) and havegpsfor the name of the scale. So it goes.This is a work in progress pending discussion. To do:
Fixes #11265