Repository navigation
TST: Fix hypothesis fuzzing logic on CI - #11128
Merged
Merged
Conversation
18 tasks done
pllim
commented
Dec 3, 2020
pllim
marked this pull request as ready for review
December 3, 2020 23:07
saimn
approved these changes
Dec 4, 2020
saimn
left a comment
saimn
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, just a little comment.
| 'fuzzing', deadline=None, print_blob=True, max_examples=1000 | ||
| ) | ||
| default = 'fuzzing' if (os.environ.get('TRAVIS_EVENT_TYPE') == 'cron' and os.environ.get('TRAVIS_CPU_ARCH') != 'arm64') else 'ci' # noqa: E501 | ||
| default = 'fuzzing' if (os.environ.get('IS_CRON') == 'true' and os.environ.get('ARCH_ON_CI') not in ('aarch64', 'ppc64le')) else 'ci' # noqa: E501 |
Contributor
There was a problem hiding this comment.
Could we print this in the pytest header or just directly so it's easy to see in the CI logs ?
Member
Author
There was a problem hiding this comment.
Great idea. I added something, let's hope it works.
pllim
commented
Dec 4, 2020
|
|
||
| env: | ||
| ARCH_ON_CI: "normal" | ||
| IS_CRON: "true" |
Member
Author
There was a problem hiding this comment.
Note: We can get fancy by setting IS_CRON using value from Actions github.event_name context (cron = 'schedule') but given that we have split cron into a separate YAML, that seems to be unnecessary.
TST: Add env reporting to test header. MNT: Remove .travis.yml from labeler. [ci skip]
[ci skip]
Member
Author
|
How does this look, @saimn ? |
Member
Author
|
Let's merge then. We'll know if fuzzing works or not when cron runs. 🤞 Thanks for the reviews, everyone! |
pllim
added a commit
to pllim/astropy
that referenced
this pull request
Mar 23, 2021
TST: Fix hypothesis fuzzing logic on CI
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request is to address
pytestconditions in test modules that were usingTRAVISenv var portion of #11038 .Note to reviewers: Please inspect logic carefully.