Repository navigation
TST: Sync Actions between 4.2.x and master branch - #11122
Conversation
|
Not sure why it says |
|
setuptools_scm guesses the next version number from the previous tag, so the version after 4.2 is 4.3, not 4.2.1 |
one of many reasons one shouldn't drop digits from versions when they are 0... |
| - name: Bundling with pyinstaller | ||
| os: ubuntu-latest | ||
| python: 3.8 | ||
| toxenv: pyinstaller |
There was a problem hiding this comment.
Maybe move this to the main workflow as well ? It seems useless to run it daily as there are not commits every day pushed to those release branches.
There was a problem hiding this comment.
All the cron files are actually push events now. I added comments to explain that I keep the files as-is for ease of backporting (in case we do a 4.2.x release).
The unused block has to be commented out. TST: Remove 32-bit job from CircleCI.
5010eee to
7c2c426
Compare
|
I cancelled Actions for the commit to remove only |
saimn
left a comment
saimn
left a comment
There was a problem hiding this comment.
Looks good! Maybe the azure failure deserves a new issue ?
|
I am pretty confident that Azure failure will go away once #11089 is merged, I just need someone to review it to make sure |
|
Let's get this in then. Thanks for the review! |
|
Just noticed that with this one we have exactly 10000 closed issues! |
|
I also snatched #11111 . Pats self on back. 😹 |
Description
This pull request is to address the 4.2.x release branch for #11050 .
Expected failures: