Repository navigation
Run cron workflows only on the main repo - #11056
Conversation
pllim
left a comment
pllim
left a comment
There was a problem hiding this comment.
Thanks! We can certainly give this a try.
Do we also want to limit the runs only to master branch?
The quotes look a little weird, so I suggested changes.
Those workflows run only on cron event, so only for master.
Good catch, thanks (the problem of copy/pasting from the internet :P) |
pllim
left a comment
pllim
left a comment
There was a problem hiding this comment.
Might wanna squash the commits. 😜
Those workflows run only on cron event, so only for master.
If we start to have this cron YAML in release branches, will cron run for those too? Do we want it to?
|
In the past I think we do run the cron jobs in releases branches but as regular jobs not cron? |
How is that possible? You customized the |
|
Actually I think the workflow will run on the branch where it is triggered, so it should work for any branch. |
|
Once this is in, it may be good to send a message to Does this affect those that followed recommendations and changed the name |
pllim
left a comment
pllim
left a comment
There was a problem hiding this comment.
I am just going to get this in now, as all the other conversations are more for a follow-up and do not block this patch. Thanks!
|
I don't think many people keep their master branch in sync with the main repo, so it should not be a problem for existing forks. |
|
True, probably unnecessary to warn people given how short a period this can have been a problem. |
To avoid running cron jobs on forks (see discussion in #11054 (comment)).
edit: I canceled the normal workflow since it is not affected by this.